Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fixed warning from Xcode 4.2 #6
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Some of the above is wrong. For instance:
sharedInstance = [[[self alloc] init] retain];
The memory management rules state that you own an object you allocate so the retain is unnecessary.
I didn't rollback any of your changes but was directed by the clang analyser to fix what seemed like leaks.
Glancing at the diff I would say that some of the accessors probably do need retains as you have shown.
I don't use RC at the moment but I think I will try and find time to build the test app as RC and see where the issues are.
As for the code base it's less than stellar. A good refactoring would be beneficial.