Fixed warning from Xcode 4.2 #6

Closed
wants to merge 13 commits into
from

Conversation

Projects
None yet
2 participants
@ruipacheco

Fixed all the exceptions we had previously and did some more clean up, thanks to Xcode 4.2

@mugginsoft

This comment has been minimized.

Show comment Hide comment
@mugginsoft

mugginsoft Aug 3, 2011

Hi Rui

Some of the above is wrong. For instance:

sharedInstance = [[[self alloc] init] retain];

The memory management rules state that you own an object you allocate so the retain is unnecessary.

I didn't rollback any of your changes but was directed by the clang analyser to fix what seemed like leaks.
This could have exposed some errors in your code.

Glancing at the diff I would say that some of the accessors probably do need retains as you have shown.
But there is too much retain noise to merge it as is.

I don't use RC at the moment but I think I will try and find time to build the test app as RC and see where the issues are.

As for the code base it's less than stellar. A good refactoring would be beneficial.

Hi Rui

Some of the above is wrong. For instance:

sharedInstance = [[[self alloc] init] retain];

The memory management rules state that you own an object you allocate so the retain is unnecessary.

I didn't rollback any of your changes but was directed by the clang analyser to fix what seemed like leaks.
This could have exposed some errors in your code.

Glancing at the diff I would say that some of the accessors probably do need retains as you have shown.
But there is too much retain noise to merge it as is.

I don't use RC at the moment but I think I will try and find time to build the test app as RC and see where the issues are.

As for the code base it's less than stellar. A good refactoring would be beneficial.

@mugginsoft mugginsoft closed this Dec 10, 2012

ghost pushed a commit to bitstadium/Fragaria that referenced this pull request Sep 1, 2015

Renamed the preferences observer because #6 leaves open a chance for …
…its consacration to a permanent component of Fragaria.

ghost pushed a commit to bitstadium/Fragaria that referenced this pull request Sep 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment