Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed critical issue #7

Closed
wants to merge 14 commits into
from

Conversation

Projects
None yet
2 participants

A retain call was missing and this caused a crash when more than one Document was open.

Hi Rui

Some of the above is wrong. For instance:

sharedInstance = [[[self alloc] init] retain];

The memory management rules state that you own an object you allocate so the retain is unnecessary.

I didn't rollback any of your changes but was directed by the clang analyser to fix what seemed like leaks.
This could have exposed some errors in your code.

Glancing at the diff I would say that some of the accessors probably do need retains as you have shown.
But there is too much retain noise to merge it as is.

I don't use RC at the moment but I think I will try and find time to build the test app as RC and see where the issues are.

As for the code base it's less than stellar. A good refactoring would be beneficial.

Owner

mugginsoft commented Dec 10, 2012

RC is now supported.

@mugginsoft mugginsoft closed this Dec 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment