Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Broken size links #14627

Closed
2 tasks done
oliviertassinari opened this issue Feb 22, 2019 · 0 comments
Closed
2 tasks done

[docs] Broken size links #14627

oliviertassinari opened this issue Feb 22, 2019 · 0 comments
Assignees
Labels
bug 馃悰 Something doesn't work docs Improvements or additions to the documentation

Comments

@oliviertassinari
Copy link
Member

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 馃

The links in the documentation are working.

Current Behavior 馃槸

We mention the bundle size in the following files:

  • /docs/src/pages/system/basics/basics.md -> link bundlephobia.com, ok
  • /docs/src/pages/demos/drawers/drawers.md -> link nothing, empirical statement, hum
  • /docs/src/pages/customization/css-in-js/css-in-js.md -> link nothing, empirical statement, hum
  • /docs/src/pages/utils/popper/popper.md -> link .size-limit.js, broken
  • /docs/src/pages/layout/use-media-query/use-media-query.md -> link .size-limit.js, broken
  • /docs/src/pages/guides/minimizing-bundle-size/minimizing-bundle-size.md link .size-limit.js, broken

Steps to Reproduce 馃暪

Navigate to https://next.material-ui.com.

Context 馃敠

The links were broken with #14587.

Your Environment 馃寧

Tech Version
Material-UI v4.0.0-alpha.1
@oliviertassinari oliviertassinari added bug 馃悰 Something doesn't work docs Improvements or additions to the documentation labels Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 馃悰 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants