Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DropDownMenu] onChange is called twice #3121

Closed
vishalvijay opened this issue Jan 31, 2016 · 4 comments
Closed

[DropDownMenu] onChange is called twice #3121

vishalvijay opened this issue Jan 31, 2016 · 4 comments
Labels
bug 🐛 Something doesn't work

Comments

@vishalvijay
Copy link
Contributor

Clicking on a MenuItem in DropDownMenu trigger onChange handler twice.

@mbrookes mbrookes changed the title [Drop Down Menu] onChange is called twice [DropDownMenu] onChange is called twice Feb 1, 2016
@alitaheri alitaheri added the bug 🐛 Something doesn't work label Feb 1, 2016
@tintin1343
Copy link
Contributor

Hi @vishalvijay . I tried reproducing the issue but I wasn't able to. Could you elaborate a bit more on this?

Does clicking on the MenuItem trigger the onChange event twice? Because I could not reproduce the same. Posting your use case or code snippet might help.

@mbrookes
Copy link
Member

@vishalvijay Some hints on what to provide when submitting an issue: https://github.com/callemall/material-ui/blob/master/CONTRIBUTING.md#opening-an-issue

@owencm
Copy link
Contributor

owencm commented Mar 18, 2016

Blind guess here: if this only happens on a mobile device then it could be due to onClick being fired for compat reasons after onTap is fired, causing a double press on the button.

If that is the issue then the solution is likely the same as we did for double touch ripples: #1563

@tintin1343
Copy link
Contributor

Closing this issue for now due to lack of response from the OP. I was able to work on something related to this and in mobiles it would be due to onTouch and onClick being fired together. The solution for double touch ripples should work in that case as pointed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

5 participants