Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider/Ripples] Janking in Chrome #4110

Closed
jeffijoe opened this issue Apr 28, 2016 · 6 comments

Comments

4 participants
@jeffijoe
Copy link

commented Apr 28, 2016

Problem Description

Using the Slider, the performance is pretty sluggish.

Here's a screenshot of the timeline:

image

Here's another one:

image

Versions

  • Material-UI: 0.14
  • React: 15
  • Browser: Chrome 50
@nathanmarks

This comment has been minimized.

Copy link
Member

commented Apr 28, 2016

Eugh! This is a good example of an issue with our styling setup:

img

@jeffijoe

This comment has been minimized.

Copy link
Author

commented Apr 28, 2016

Prefixing for each frame can't possibly be fast.

@nathanmarks

This comment has been minimized.

Copy link
Member

commented Apr 28, 2016

@jeffijoe The styling situation is causing a bunch of issues including poor performance in many scenarios. I've opened a discussion on what the solution should be here #4066 , would appreciate any input!

@mpontikes

This comment has been minimized.

Copy link

commented Aug 4, 2016

@jeffijoe Should this be closed in favor of #4066?

@jeffijoe

This comment has been minimized.

Copy link
Author

commented Aug 5, 2016

@mpontikes if the end result is moving away from prefixing inline styles, then yes.

@oliviertassinari

This comment has been minimized.

Copy link
Member

commented Jul 28, 2017

Yes, let's close this issue for #4066.
Also, the performance of the styling solution are much better on the v1-beta branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.