Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[core] Fix jss v10 types being used #14117
left a comment
Wow, I would have never imagined a solution was possible in the TypeScript land. I have tried to better use the resolution feature of yarn to scope jss v9 and v10 in the documentation without luck.
This is basically what https://github.com/DefinitelyTyped/DefinitelyTyped#i-want-to-update-a-package-to-a-new-major-version describes. Just not as pretty since v10 is not published under
Jan 8, 2019
10 checks passed
Having compile issues, seems as though types originally matched the v10 alpha, and the changes to type were to match a different version, but the package json has not been updated to not use v10 so there is a mismatch with the types and the linked package.
From running typescript compiler:
reverting to 3.8.2 allows us to compile
This should be reflected in
Could list your package.json? If you have