[IconButton] Warn when providing onClick to a child of a button #14160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
new feature
eps1lon
previously requested changes
Jan 12, 2019
oliviertassinari
force-pushed
the
button-warn-firefox
branch
2 times, most recently
from
a3ed62d
to
a358462
Compare
oliviertassinari
dismissed
eps1lon’s stale review
Haha, you have reviewed too quickly, the pull-request wasn't green yet. thank you.
oliviertassinari
force-pushed
the
button-warn-firefox
branch
2 times, most recently
from
a21d590
to
9428615
Compare
|
@eps1lon It's ready for review :). |
eps1lon
previously requested changes
Jan 12, 2019
oliviertassinari
force-pushed
the
button-warn-firefox
branch
from
fc1a2c1
to
40c11c9
Compare
| @@ -20,36 +20,36 @@ | |||
| }, | |||
| "homepage": "https://material-ui.com/", | |||
| "scripts": { | |||
| "start": "yarn docs:dev", | |||
There was a problem hiding this comment.
alphabetical sort
oliviertassinari
force-pushed
the
button-warn-firefox
branch
from
40c11c9
to
79b0ea9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help with #13957.