Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update bundle size strategy #14662

Merged
merged 1 commit into from Feb 26, 2019

Conversation

@eps1lon
Copy link
Member

commented Feb 25, 2019

Closes #14627

I looked into adding redirects after a deploy finished on netlify or uploading additional files but it doesn't look like this is supported.

We could just move the build of the deploy to CI and then upload the full deploy. That's however way more code compared to simply changing a redirect when we switch default branches.

See eps1lon/persist-size-snapshot@89f132e

@eps1lon eps1lon added bug docs labels Feb 25, 2019

@mui-pr-bot

This comment has been minimized.

Copy link

commented Feb 25, 2019

No bundle size changes comparing 6b68487...f192fbe

Generated by 🚫 dangerJS against f192fbe

@oliviertassinari oliviertassinari merged commit b1b37e2 into mui-org:next Feb 26, 2019

14 of 15 checks passed

Pages changed 230 new files uploaded
Details
Header rules 4 header rules processed
Details
Mixed content No mixed content detected
Details
Redirect rules 82 redirect rules processed
Details
argos Everything good!
Details
ci/circleci: checkout Your tests passed on CircleCI!
Details
ci/circleci: size_snapshot Your tests passed on CircleCI!
Details
ci/circleci: test_browser Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_material-ui-x Your tests passed on CircleCI!
Details
ci/circleci: test_regressions Your tests passed on CircleCI!
Details
ci/circleci: test_unit Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6b68487...f192fbe
Details
codecov/project 100% remains the same compared to 6b68487
Details
deploy/netlify Deploy preview ready!
Details

@eps1lon eps1lon deleted the eps1lon:docs/bundle-size branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.