[core] Remove dom-helpers dependency #14877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
kill-dom-helpers
branch
3 times, most recently
from
b25995e
to
15c968f
Compare
| const marginRight = parseInt(style.getPropertyValue('margin-right'), 10); | ||
|
|
||
| return marginLeft + doc.body.clientWidth + marginRight < win.innerWidth; | ||
| return container.scrollHeight > container.clientHeight; |
There was a problem hiding this comment.
| @@ -17,7 +17,8 @@ function findIndexOf(data, callback) { | |||
| } | |||
|
|
|||
| function getPaddingRight(node) { | |||
| return parseInt(css(node, 'paddingRight') || 0, 10); | |||
| const win = ownerWindow(node); | |||
| return parseInt(win.getComputedStyle(node)['padding-right'] || 0, 10); | |||
There was a problem hiding this comment.
|
@material-ui/core: parsed: -1.26% 😍, gzip: -1.46% 😍 Details of bundle changes.Comparing: bdb4baa...09babf7
|
joshwooding
reviewed
Mar 13, 2019
|
I will continue the effort tomorrow, I was interested in the gain potential. It's worth pushing. |
eps1lon
reviewed
Mar 13, 2019
oliviertassinari
force-pushed
the
kill-dom-helpers
branch
from
15c968f
to
4d2e6e9
Compare
|
The biggest win comes from: -import css from 'dom-helpers/style';
-return parseInt(css(node, 'paddingRight') || 0, 10);
+return parseInt(win.getComputedStyle(node)['padding-right'] || 0, 10); |
oliviertassinari
force-pushed
the
kill-dom-helpers
branch
2 times, most recently
from
8380212
to
e7a847d
Compare
oliviertassinari
force-pushed
the
kill-dom-helpers
branch
from
e7a847d
to
5bf5528
Compare
eps1lon
reviewed
Mar 14, 2019
| container1.style.padding = '20px'; | ||
| Object.defineProperty(container1, 'scrollHeight', { | ||
| value: 100, | ||
| writable: false, |
There was a problem hiding this comment.
This will not really prevent writing. All it does is throw an error. I would rather sinon.stub this with a fake setter:
sinon.stub(container1, 'scrollHeight').get(() => 100).set(() => {})
writable: false will actually not trigger an error. Would've been nice if sinon would support this out of the box.
| @@ -113,15 +122,22 @@ describe('ModalManager', () => { | |||
| it('should handle the scroll', () => { | |||
| const modal = {}; | |||
| const paddingRightBefore = container1.style.paddingRight; | |||
| const paddingFixedRightBefore = fixedNode.style.paddingRight; | |||
There was a problem hiding this comment.
Is this just refactoring or did the test actually break?
There was a problem hiding this comment.
So this is a breaking change after all or only breaking in jsdom?
There was a problem hiding this comment.
I think that it's only breaking jsdom.
oliviertassinari
force-pushed
the
kill-dom-helpers
branch
from
1138b5f
to
09babf7
Compare
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save -4.92% gzipped on the Modal component.