Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Add a downshift variant demo #14881

Merged
merged 5 commits into from Mar 15, 2019

Conversation

3 participants
@ekoeditaa
Copy link
Contributor

commented Mar 14, 2019

Added demos for downshift based on #13611.

Do you guys think we need to add the same things for the multiple select and popper?

Closes #13611.

ekoeditaa added some commits Mar 14, 2019

Refactor current downshift integration demo
Extract out common constants and functions
Add new downshift demo
- shows certain number of options on focus
- search for all string, not only just strings beginning with the text
- clear downshift value when `TextField` is cleared

@ekoeditaa ekoeditaa changed the title Add downshift demos [Autocomplete] Add downshift demos Mar 14, 2019

@mui-pr-bot

This comment has been minimized.

Copy link

commented Mar 14, 2019

No bundle size changes comparing bdb4baa...06a3a63

Generated by 🚫 dangerJS against 06a3a63

@oliviertassinari oliviertassinari self-assigned this Mar 14, 2019

});
}

class DownshiftMultiple extends React.Component {

This comment has been minimized.

Copy link
@ekoeditaa

ekoeditaa Mar 14, 2019

Author Contributor

Kept this class here in case we want to implement the demo with multiple select also.

@oliviertassinari

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

There are too many line changes in comparison to the related issue. Is there is a way to make minimal changes?

@ekoeditaa

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

@oliviertassinari Hmm yes. Let me do the changes.

@ekoeditaa

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

@oliviertassinari much smaller changeset now. Thank you!

@oliviertassinari oliviertassinari force-pushed the ekoeditaa:add-downshift-demos branch from aca5fa6 to de73d3a Mar 14, 2019

@oliviertassinari oliviertassinari force-pushed the ekoeditaa:add-downshift-demos branch from de73d3a to 06a3a63 Mar 14, 2019

@oliviertassinari oliviertassinari removed their assignment Mar 14, 2019

@oliviertassinari oliviertassinari changed the title [Autocomplete] Add downshift demos [Autocomplete] Add a downshift variant demo Mar 14, 2019

@oliviertassinari oliviertassinari merged commit b94cbff into mui-org:next Mar 15, 2019

13 of 14 checks passed

Pages changed 232 new files uploaded
Details
Header rules 4 header rules processed
Details
Mixed content No mixed content detected
Details
Redirect rules 83 redirect rules processed
Details
argos Difference accepted.
Details
ci/circleci: checkout Your tests passed on CircleCI!
Details
ci/circleci: size_snapshot Your tests passed on CircleCI!
Details
ci/circleci: test_browser Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_material-ui-x Your tests passed on CircleCI!
Details
ci/circleci: test_regressions Your tests passed on CircleCI!
Details
ci/circleci: test_unit Your tests passed on CircleCI!
Details
codecov/project 99.39% remains the same compared to 89ebedc
Details
deploy/netlify Deploy preview ready!
Details
@oliviertassinari

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

@ekoeditaa thanks

@ekoeditaa ekoeditaa deleted the ekoeditaa:add-downshift-demos branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.