Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lab] Consume correct core utils in lab #15995

Merged
merged 2 commits into from Jun 1, 2019

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Jun 1, 2019

Commonjs appeared because of using deep path import

Commonjs appeared because of using deep path import
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 1, 2019

@material-ui/lab: parsed: -0.39% 😍, gzip: -0.45% 😍

Details of bundle changes.

Comparing: 60071b8...b9cf699

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.00% -0.00% 317,195 317,194 86,939 86,937
@material-ui/core/Paper -0.00% +0.02% 🔺 67,922 67,921 20,181 20,186
@material-ui/core/Paper.esm 0.00% +0.01% 🔺 61,217 61,217 18,977 18,978
@material-ui/core/Popper 0.00% 0.00% 28,728 28,728 10,345 10,345
@material-ui/core/Textarea 0.00% -0.04% 5,513 5,513 2,378 2,377
@material-ui/core/TrapFocus 0.00% 0.00% 3,744 3,744 1,573 1,573
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,978 15,978 5,786 5,786
@material-ui/core/useMediaQuery 0.00% -0.10% 2,106 2,106 974 973
@material-ui/lab -0.39% -0.45% 138,855 138,313 42,673 42,483
@material-ui/styles 0.00% +0.01% 🔺 51,386 51,386 15,193 15,194
@material-ui/system 0.00% 0.00% 14,463 14,463 4,178 4,178
Button 0.00% 0.00% 83,901 83,902 25,467 25,467
Modal 0.00% -0.01% 20,331 20,331 6,686 6,685
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% +0.01% 🔺 55,977 55,977 14,041 14,042
docs.main 0.00% 0.00% 649,319 649,319 204,831 204,832
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 291,089 291,089 83,267 83,267

Generated by 🚫 dangerJS against b9cf699

@oliviertassinari
Copy link
Member

Should we fix all the occurrences?

@TrySound
Copy link
Contributor Author

TrySound commented Jun 1, 2019

I found only this one in lab

@TrySound
Copy link
Contributor Author

TrySound commented Jun 1, 2019

Ah, I see docs and tests too

@oliviertassinari oliviertassinari changed the title Consume correct core utils in lab [core] Consume correct core utils in lab Jun 1, 2019
@oliviertassinari oliviertassinari changed the title [core] Consume correct core utils in lab [lab] Consume correct core utils in lab Jun 1, 2019
@oliviertassinari oliviertassinari added the package: lab Specific to @mui/lab label Jun 1, 2019
@mui mui deleted a comment from codecov bot Jun 1, 2019
@oliviertassinari oliviertassinari merged commit 5abdedd into mui:master Jun 1, 2019
@oliviertassinari
Copy link
Member

@TrySound Thanks

@TrySound TrySound deleted the lab-correct-utils branch June 2, 2019 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: lab Specific to @mui/lab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants