Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Revert strict mode compatible transition components #16348

Merged
merged 1 commit into from Jun 24, 2019

Conversation

@eps1lon
Copy link
Member

commented Jun 24, 2019

Reverts #16283 which was a breaking change for Snackbar with custom children i.e. not components from @material-ui/*.

Closes #16347

@mui-pr-bot

This comment has been minimized.

Copy link

commented Jun 24, 2019

@material-ui/core: parsed: -0.15% 😍, gzip: -0.11% 😍

Details of bundle changes.

Comparing: 0bee9a7...985ca67

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.15% -0.11% 320,509 320,016 88,449 88,351
@material-ui/core/Paper 0.00% 0.00% 68,278 68,278 20,363 20,363
@material-ui/core/Paper.esm 0.00% 0.00% 61,573 61,573 19,161 19,161
@material-ui/core/Popper 0.00% +0.04% 🔺 28,945 28,945 10,391 10,395
@material-ui/core/Textarea 0.00% -0.08% 5,513 5,513 2,376 2,374
@material-ui/core/TrapFocus 0.00% 0.00% 3,753 3,753 1,578 1,578
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,009 16,009 5,791 5,791
@material-ui/core/useMediaQuery 0.00% 0.00% 2,597 2,597 1,102 1,102
@material-ui/lab -0.21% -0.19% 140,344 140,052 43,471 43,387
@material-ui/styles 0.00% 0.00% 51,698 51,698 15,348 15,348
@material-ui/system 0.00% 0.00% 15,420 15,420 4,391 4,391
Button -0.16% -0.18% 84,430 84,296 25,758 25,712
Modal 0.00% +0.02% 🔺 14,427 14,427 5,086 5,087
Portal 0.00% +0.06% 🔺 3,473 3,473 1,571 1,572
Slider 0.00% +0.02% 🔺 74,752 74,752 23,240 23,245
colorManipulator 0.00% 0.00% 3,904 3,904 1,544 1,544
docs.landing 0.00% 0.00% 55,119 55,119 13,941 13,941
docs.main -0.09% -0.14% 649,042 648,454 204,800 204,506
packages/material-ui/build/umd/material-ui.production.min.js -0.15% -0.15% 293,672 293,222 84,362 84,233

Generated by 🚫 dangerJS against 985ca67

@eps1lon eps1lon merged commit 7610ed9 into mui-org:master Jun 24, 2019

14 of 15 checks passed

Pages changed 255 new files uploaded
Details
Header rules 4 header rules processed
Details
Mixed content No mixed content detected
Details
Redirect rules 100 redirect rules processed
Details
argos Everything good!
Details
ci/circleci: checkout Your tests passed on CircleCI!
Details
ci/circleci: test_browser Your tests passed on CircleCI!
Details
ci/circleci: test_material-ui-x Your tests passed on CircleCI!
Details
ci/circleci: test_production Your tests passed on CircleCI!
Details
ci/circleci: test_regressions Your tests passed on CircleCI!
Details
ci/circleci: test_static Your tests passed on CircleCI!
Details
ci/circleci: test_unit Your tests passed on CircleCI!
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +0.99% compared to 0bee9a7
Details
deploy/netlify Deploy preview ready!
Details
mui-org.material-ui Build #20190624.1 succeeded
Details

@eps1lon eps1lon deleted the eps1lon:revert-rtg-strict branch Jun 24, 2019

@oliviertassinari oliviertassinari referenced this pull request Jun 24, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.