New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Fix support for limitTags={0} #20850
Merged
oliviertassinari
merged 3 commits into
mui:master
from
tykdn:feature/Autocomplete-support-for-zero-limitTags
May 2, 2020
Merged
[Autocomplete] Fix support for limitTags={0} #20850
oliviertassinari
merged 3 commits into
mui:master
from
tykdn:feature/Autocomplete-support-for-zero-limitTags
May 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: ab026b1...31be144 Details of page changes
|
joshwooding
added
component: autocomplete
This is the name of the generic UI component, not the React module!
bug 🐛
Something doesn't work
labels
Apr 30, 2020
joshwooding
changed the title
[Autocomplete] support for limitTags={0} (#20815)
[Autocomplete] support for limitTags={0}
Apr 30, 2020
joshwooding
suggested changes
Apr 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test?
@joshwooding Yes,I will add a UT case. |
oliviertassinari
changed the title
[Autocomplete] support for limitTags={0}
[Autocomplete] Fix support for limitTags={0}
May 1, 2020
tykdn
force-pushed
the
feature/Autocomplete-support-for-zero-limitTags
branch
from
May 2, 2020 00:31
7db9ad2
to
de68a1c
Compare
tykdn
force-pushed
the
feature/Autocomplete-support-for-zero-limitTags
branch
from
May 2, 2020 00:44
de68a1c
to
3d8278a
Compare
joshwooding
approved these changes
May 2, 2020
@tykdn It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: autocomplete
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20815