Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Small changes #22020

Merged
merged 18 commits into from Aug 4, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 1, 2020

  • [core] import * as React from 'react' a1d5aeb: Noticed a few cases that diverge from the convention
  • [core] Resolve hesitation between @return vs. @returns 7913d02: the two are aliases, I went with @returns because more popular (in the codebase).
  • [core] Remove blank line for consistency 8d0d352: follow the convention
  • [test] Fix test:coverage:html 7b3faab: the command got out of date
  • [core] Sort gitignore ASC e1e52df: so we don't have to ask ourselves, where should I put the new value.
  • [docs] Simpler > easier c851384: simple: one bread, easy: no effort. Isn't simplicity a better property to aim for than easiness?
  • [docs] v5 in Q3 is unrealistic 2f135bd
  • [core] Point to next over master c4fcc2a:
  • [docs] We don't allow the .jsx extension 4b15574:
  • [job] Add levels 07d64fb:
  • [docs] Skip anchor link for h1 9b980c7: the anchor on the h1 duplicates with the naked URL, it's noise. I found it with Algolia that always returns an anchor even when it matches the top of the page. reactjs.org does the same, docusaurus.io and many others too.
  • [test] Improve lint commands 3e1442b: a small detail we changed in the x repository so we could add a CSS lint stage.

@oliviertassinari oliviertassinari added the umbrella For grouping multiple issues to provide a holistic view label Aug 1, 2020
.circleci/config.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 2, 2020
@oliviertassinari oliviertassinari removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 2, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 2, 2020

Details of bundle changes

Generated by 🚫 dangerJS against 144bf74

eps1lon
eps1lon previously requested changes Aug 3, 2020
package.json Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari merged commit e1e8e82 into mui:next Aug 4, 2020
@oliviertassinari oliviertassinari deleted the batch-small-changes-v26 branch August 4, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants