Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Set aria-expanded to false when listbox is collapsed #25545

Merged
merged 2 commits into from Mar 30, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 29, 2021

I have updated the aria attribute of select box to be false when list box is collapsed and updated the test files to check for the same.

One chunk of #25399

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 29, 2021

Details of bundle changes

Generated by 🚫 dangerJS against aac996c

@eps1lon eps1lon changed the title [Select] Set aria-expanded to false when listbox is collapsed. (#25399) [Select] Set aria-expanded to false when listbox is collapsed Mar 29, 2021
@eps1lon eps1lon added component: select This is the name of the generic UI component, not the React module! new feature New feature or request labels Mar 29, 2021
@eps1lon eps1lon added the accessibility a11y label Mar 29, 2021
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the demos of https://next.material-ui.com/components/menus/ at the same time?

@eps1lon
Copy link
Member

eps1lon commented Mar 29, 2021

Should we update the demos of next.material-ui.com/components/menus at the same time?

Can be done in a separate PR since these are different components.

@oliviertassinari oliviertassinari merged commit 7f0b590 into mui:next Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y component: select This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select] aria-expanded not getting set to "false" when listbox collapsed
4 participants