New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.0.3 #28885
v5.0.3 #28885
Conversation
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@mui/styled-engine-sc", | |||
"version": "5.0.0", | |||
"version": "5.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is strange. It should be 5.0.1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We agreed to bump the version of public packages to match the 'global' version. According to semver it's ok to skip some versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't actually have a global version. We have packages that had more breaking changes and therefore require more major version releases.
A global version would make it impossible to independently release packages. This is fine now but constrains you in the future where you want more loosely coupled packages (headless -> unstyled -> styled).
So if you want to bump it, then bump it. But "we have a global version" is not true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaldudak To be clear, this one is done manually right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A global version would make it impossible to independently release packages. This is fine now but constrains you in the future where you want more loosely coupled packages (headless -> unstyled -> styled).
Agree.
To be clear, this one is done manually right?
Yes, I specified the custom version number when running yarn release:version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just merged some stuff so pleae rebase and update the changelog
009533d
to
69efb6a
Compare
c4fe5ed
to
e78e9ed
Compare
No description provided.