Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.3 #28885

Merged
merged 5 commits into from Oct 7, 2021
Merged

v5.0.3 #28885

merged 5 commits into from Oct 7, 2021

Conversation

michaldudak
Copy link
Member

No description provided.

@michaldudak michaldudak requested a review from a team October 7, 2021 07:12
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 7, 2021

No bundle size changes

Generated by 🚫 dangerJS against 4e14b14

benchmark/package.json Outdated Show resolved Hide resolved
@@ -1,6 +1,6 @@
{
"name": "@mui/styled-engine-sc",
"version": "5.0.0",
"version": "5.0.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange. It should be 5.0.1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed to bump the version of public packages to match the 'global' version. According to semver it's ok to skip some versions.

Copy link
Member

@eps1lon eps1lon Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually have a global version. We have packages that had more breaking changes and therefore require more major version releases.

A global version would make it impossible to independently release packages. This is fine now but constrains you in the future where you want more loosely coupled packages (headless -> unstyled -> styled).

So if you want to bump it, then bump it. But "we have a global version" is not true.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaldudak To be clear, this one is done manually right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A global version would make it impossible to independently release packages. This is fine now but constrains you in the future where you want more loosely coupled packages (headless -> unstyled -> styled).

Agree.

To be clear, this one is done manually right?

Yes, I specified the custom version number when running yarn release:version

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just merged some stuff so pleae rebase and update the changelog

@michaldudak michaldudak force-pushed the release/5.0.3 branch 2 times, most recently from 009533d to 69efb6a Compare October 7, 2021 08:54
@michaldudak michaldudak merged commit 3625803 into mui:master Oct 7, 2021
@michaldudak michaldudak deleted the release/5.0.3 branch October 7, 2021 12:19
@oliviertassinari oliviertassinari mentioned this pull request Oct 10, 2021
1 task
@zannager zannager added the core Infrastructure work going on behind the scenes label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants