[docs] Add JSDoc to theme.breakpoints
#29039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
docs
eps1lon
force-pushed
the
docs/breakpoints-api
branch
from
7812ee0
to
fa1fcd4
Compare
eps1lon
force-pushed
the
docs/breakpoints-api
branch
from
fa1fcd4
to
0305939
Compare
siriwatknp
approved these changes
Oct 14, 2021
|
Forgot to add the proof-of-work I originally recorded: breakpoints-jsdoc.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps discoverability of APIs available in
theme.breakpointsin response to feedback received in #29037.This includes a type change to
createTheme({ breakpoints: { step }})wheresteppreviously accepted astringeven though we implicitly convert it to anumberin https://github.com/mui-org/material-ui/blob/49b3469442d45329df59e524fd31a2ce6ff311cc/packages/mui-system/src/createTheme/createBreakpoints.js#L31breakpoints-jsdoc.mp4