Skip to content

[code-infra] Update pnpm and clean lint ignores#4889

Draft
lyzno1 wants to merge 7 commits into
mui:masterfrom
lyzno1:codex/update-pnpm-and-lint-ignores
Draft

[code-infra] Update pnpm and clean lint ignores#4889
lyzno1 wants to merge 7 commits into
mui:masterfrom
lyzno1:codex/update-pnpm-and-lint-ignores

Conversation

@lyzno1
Copy link
Copy Markdown
Contributor

@lyzno1 lyzno1 commented May 22, 2026

Summary

  • Update pnpm to 11.2.2.
  • Move pnpm config from .npmrc to pnpm-workspace.yaml.
  • Remove obsolete lint ignores and symlink CLAUDE.md to AGENTS.md.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b38183ced

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 22, 2026

commit: ef0df9f

@code-infra-dashboard
Copy link
Copy Markdown

code-infra-dashboard Bot commented May 22, 2026

Bundle size

Bundle Parsed size Gzip size
@base-ui/react 0B(0.00%) 0B(0.00%)

Details of bundle changes

Performance

Total duration: 1,136.35 ms -112.67 ms(-9.0%) | Renders: 50 (+0) | Paint: 1,736.14 ms -159.24 ms(-8.4%)

Test Duration Renders
Slider mount (300 instances) 147.77 ms ▼-54.01 ms(-26.8%) 3 (+0)

11 tests within noise — details


Check out the code infra dashboard for more information about this PR.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 22, 2026

Deploy Preview for base-ui ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ef0df9f
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a10461025290e0007b9a92c
😎 Deploy Preview https://deploy-preview-4889--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review

AGENTS.md

P2 Badge Preserve CLAUDE.md fallback for non-symlink checkouts

Replacing CLAUDE.md with a symlink target string (AGENTS.md) breaks instruction loading on environments where symlinks are not materialized (commonly Windows with core.symlinks=false): Git checks out a plain text file, and Claude reads CLAUDE.md literally, so AGENTS.md is not treated as an import. That means repository guidance is silently skipped for those contributors unless the file contains @AGENTS.md (or a real symlink is guaranteed).

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lyzno1 lyzno1 marked this pull request as draft May 22, 2026 11:53
@lyzno1
Copy link
Copy Markdown
Contributor Author

lyzno1 commented May 22, 2026

This should stay draft for now. The pnpm 11 migration needs the shared CircleCI orb in mui-public to support passing pnpm dlx build approvals for package-overrides first; otherwise the React 18 jobs can hang on the interactive build selection prompt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant