From 2ae9d4ca30ed40c425e6bbe08614a83b7d389f92 Mon Sep 17 00:00:00 2001 From: Sebastian Silbermann Date: Tue, 2 Jun 2020 14:09:53 +0200 Subject: [PATCH] [Dialog] Fix dialog children being considered clickable --- packages/material-ui/src/Dialog/Dialog.js | 3 +-- packages/material-ui/src/Dialog/Dialog.test.js | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/material-ui/src/Dialog/Dialog.js b/packages/material-ui/src/Dialog/Dialog.js index 671b4aca8e5917..54d2db7a8129ca 100644 --- a/packages/material-ui/src/Dialog/Dialog.js +++ b/packages/material-ui/src/Dialog/Dialog.js @@ -1,4 +1,3 @@ -/* eslint-disable jsx-a11y/click-events-have-key-events */ import * as React from 'react'; import PropTypes from 'prop-types'; import clsx from 'clsx'; @@ -234,7 +233,7 @@ const Dialog = React.forwardRef(function Dialog(props, ref) { {/* eslint-disable-next-line jsx-a11y/no-static-element-interactions */}
diff --git a/packages/material-ui/src/Dialog/Dialog.test.js b/packages/material-ui/src/Dialog/Dialog.test.js index 776ccd0b32302a..6cad38e233fe54 100644 --- a/packages/material-ui/src/Dialog/Dialog.test.js +++ b/packages/material-ui/src/Dialog/Dialog.test.js @@ -14,6 +14,7 @@ import Dialog from './Dialog'; */ function userClick(element) { fireEvent.mouseDown(element); + fireEvent.mouseUp(element); element.click(); }