diff --git a/docs/src/modules/components/AppContent.js b/docs/src/modules/components/AppContent.js index 5262b4eb2eaade..e105a2db387c70 100644 --- a/docs/src/modules/components/AppContent.js +++ b/docs/src/modules/components/AppContent.js @@ -36,7 +36,7 @@ function AppContent(props) { - } /> - } /> - } /> + } aria-label="Phone" /> + } aria-label="Favorite" /> + } aria-label="Person" /> ); diff --git a/docs/src/pages/demos/tabs/IconTabs.tsx b/docs/src/pages/demos/tabs/IconTabs.tsx index 65f1e4fe95f04f..fc2efdbef4e6d8 100644 --- a/docs/src/pages/demos/tabs/IconTabs.tsx +++ b/docs/src/pages/demos/tabs/IconTabs.tsx @@ -31,9 +31,9 @@ function IconTabs() { indicatorColor="primary" textColor="primary" > - } /> - } /> - } /> + } aria-label="Phone" /> + } aria-label="Favorite" /> + } aria-label="Person" /> ); diff --git a/docs/src/pages/demos/tabs/ScrollableTabsButtonPrevent.js b/docs/src/pages/demos/tabs/ScrollableTabsButtonPrevent.js index 16eb7b1ddf46a9..e58b5f98282dfb 100644 --- a/docs/src/pages/demos/tabs/ScrollableTabsButtonPrevent.js +++ b/docs/src/pages/demos/tabs/ScrollableTabsButtonPrevent.js @@ -45,13 +45,13 @@ function ScrollableTabsButtonPrevent() {
- } /> - } /> - } /> - } /> - } /> - } /> - } /> + } aria-label="Phone" /> + } aria-label="Favorite" /> + } aria-label="Person" /> + } aria-label="Help" /> + } aria-label="Shopping" /> + } aria-label="Up" /> + } aria-label="Down" /> {value === 0 && Item One} diff --git a/docs/src/pages/demos/tabs/ScrollableTabsButtonPrevent.tsx b/docs/src/pages/demos/tabs/ScrollableTabsButtonPrevent.tsx index 82aafa5155fa4a..be0d8652bb1a37 100644 --- a/docs/src/pages/demos/tabs/ScrollableTabsButtonPrevent.tsx +++ b/docs/src/pages/demos/tabs/ScrollableTabsButtonPrevent.tsx @@ -49,13 +49,13 @@ function ScrollableTabsButtonPrevent() {
- } /> - } /> - } /> - } /> - } /> - } /> - } /> + } aria-label="Phone" /> + } aria-label="Favorite" /> + } aria-label="Person" /> + } aria-label="Help" /> + } aria-label="Shopping" /> + } aria-label="Up" /> + } aria-label="Down" /> {value === 0 && Item One} diff --git a/packages/material-ui/src/Backdrop/Backdrop.js b/packages/material-ui/src/Backdrop/Backdrop.js index 73b96b33f9f2cc..9619d3d694f2a8 100644 --- a/packages/material-ui/src/Backdrop/Backdrop.js +++ b/packages/material-ui/src/Backdrop/Backdrop.js @@ -39,7 +39,7 @@ const Backdrop = React.forwardRef(function Backdrop(props, ref) { }, className, )} - aria-hidden="true" + aria-hidden ref={ref} /> diff --git a/packages/material-ui/src/Breadcrumbs/BreadcrumbSeparator.js b/packages/material-ui/src/Breadcrumbs/BreadcrumbSeparator.js index a87d4d6924498d..94f30067de0f26 100644 --- a/packages/material-ui/src/Breadcrumbs/BreadcrumbSeparator.js +++ b/packages/material-ui/src/Breadcrumbs/BreadcrumbSeparator.js @@ -18,7 +18,7 @@ const styles = { function BreadcrumbSeparator(props) { const { classes, className, ...other } = props; - return
  • ; } BreadcrumbSeparator.propTypes = { diff --git a/packages/material-ui/src/ButtonBase/ButtonBase.js b/packages/material-ui/src/ButtonBase/ButtonBase.js index 4dbaaa4125e79f..4977ab46a75d77 100644 --- a/packages/material-ui/src/ButtonBase/ButtonBase.js +++ b/packages/material-ui/src/ButtonBase/ButtonBase.js @@ -309,7 +309,7 @@ class ButtonBase extends React.Component { setRef(buttonRef, ref); setRef(innerRef, ref); }} - tabIndex={disabled ? '-1' : tabIndex} + tabIndex={disabled ? -1 : tabIndex} {...buttonProps} {...other} > @@ -468,7 +468,7 @@ ButtonBase.defaultProps = { disableRipple: false, disableTouchRipple: false, focusRipple: false, - tabIndex: '0', + tabIndex: 0, type: 'button', }; diff --git a/packages/material-ui/src/ButtonBase/ButtonBase.test.js b/packages/material-ui/src/ButtonBase/ButtonBase.test.js index cbda9afd77c743..df764f893f45e5 100644 --- a/packages/material-ui/src/ButtonBase/ButtonBase.test.js +++ b/packages/material-ui/src/ButtonBase/ButtonBase.test.js @@ -50,7 +50,7 @@ describe('', () => { it('should change the button component and add accessibility requirements', () => { const wrapper = mount(); const checkbox = wrapper.find('span[role="checkbox"]'); - assert.strictEqual(checkbox.props().tabIndex, '0'); + assert.strictEqual(checkbox.props().tabIndex, 0); }); it('should not apply role="button" if type="button"', () => { @@ -381,7 +381,7 @@ describe('', () => { describe('prop: disabled', () => { it('should not receive the focus', () => { const wrapper = mount(Hello); - assert.strictEqual(wrapper.find('button').props().tabIndex, '-1'); + assert.strictEqual(wrapper.find('button').props().tabIndex, -1); }); it('should also apply it when using component', () => { diff --git a/packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.js b/packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.js index 8321335d8407a3..b026cf9a6bcf30 100644 --- a/packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.js +++ b/packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.js @@ -136,7 +136,7 @@ const ExpansionPanelSummary = React.forwardRef(function ExpansionPanelSummary(pr edge="end" component="div" tabIndex={-1} - aria-hidden="true" + aria-hidden {...IconButtonProps} > {expandIcon} diff --git a/packages/material-ui/src/Icon/Icon.js b/packages/material-ui/src/Icon/Icon.js index e876f580bb18a7..375f44b02cba2d 100644 --- a/packages/material-ui/src/Icon/Icon.js +++ b/packages/material-ui/src/Icon/Icon.js @@ -63,7 +63,7 @@ const Icon = React.forwardRef(function Icon(props, ref) { }, className, )} - aria-hidden="true" + aria-hidden ref={ref} {...other} /> diff --git a/packages/material-ui/src/InputBase/Textarea.js b/packages/material-ui/src/InputBase/Textarea.js index 56700d446ee1d2..e1ba65ef600471 100644 --- a/packages/material-ui/src/InputBase/Textarea.js +++ b/packages/material-ui/src/InputBase/Textarea.js @@ -127,7 +127,7 @@ const Textarea = React.forwardRef(function Textarea(props, ref) { {...other} />