New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump eslint-plugin-react to ^7.30.1 #33027
Conversation
Your Render PR Server URL is https://mui-pr-33027.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cadvu9fd17c944c09d10. |
ccfc057
to
9ab2d3c
Compare
9ab2d3c
to
8f672ea
Compare
8f672ea
to
286f816
Compare
286f816
to
8f35e29
Compare
8f35e29
to
f5bd2a1
Compare
f5bd2a1
to
f389f17
Compare
9b2b8ae
to
95ef67c
Compare
@@ -247,6 +247,10 @@ function FixtureRenderer({ component: FixtureComponent }) { | |||
return null; | |||
} | |||
|
|||
FixtureRenderer.propTypes = { | |||
component: PropTypes.element, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// No need to check this as prop types are autogenerated. | ||
// Plus, there are a few false positives. | ||
'react/no-unused-prop-types': 'off', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-unused-prop-types.md and mui/mui-toolpad#866 (comment), it seems that we should revert. This impacts TypeScript too.
Co-authored-by: Michał Dudak <michal@dudak.me>
This PR contains the following updates:
^7.29.4
->^7.30.1
Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.