Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooltip][Joy] Turn JS test to TS test #37149

Merged
merged 2 commits into from
May 11, 2023

Conversation

nicolas-ot
Copy link
Contributor

@nicolas-ot nicolas-ot commented May 3, 2023

part of #37078

@mui-bot
Copy link

mui-bot commented May 3, 2023

Netlify deploy preview

https://deploy-preview-37149--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against de251e3

@zannager zannager added component: tooltip This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels May 3, 2023
@zannager zannager requested a review from hbjORbj May 3, 2023 12:23
import { unstable_capitalize as capitalize } from '@mui/utils';

describe('<Tooltip />', () => {
const { render } = createRenderer();

function TestPopper(props) {
function TestPopper(props: any) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function TestPopper(props: any) {
function TestPopper(props: Omit<PopperProps, 'children'> & { 'data-testid': string; children: any }) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@nicolas-ot nicolas-ot changed the title [Tooltip] Turn JS test to TS test [Tooltip][Joy] Turn JS test to TS test May 3, 2023
@nicolas-ot
Copy link
Contributor Author

nicolas-ot commented May 10, 2023

hey @hbjORbj , just making sure you remember this PR exists because you haven't linked this PR in the main issue

Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@hbjORbj hbjORbj merged commit 126714d into mui:master May 11, 2023
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tooltip This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants