[Base][Tab] Add vertical tabs demo #37292
Merged
+250
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
docs
Netlify deploy previewBundle size report |
zanivan
approved these changes
May 18, 2023
| @@ -67,6 +67,12 @@ The next demo shows how to apply custom styles to a set of tabs: | |||
|
|
|||
| {{"demo": "UnstyledTabsCustomized.js"}} | |||
|
|
|||
| ### Vertical | |||
There was a problem hiding this comment.
Can you move this section down to underneath the ## Customization header? It can be the first item, above the section about TypeScript.
| @@ -67,6 +67,12 @@ The next demo shows how to apply custom styles to a set of tabs: | |||
|
|
|||
| {{"demo": "UnstyledTabsCustomized.js"}} | |||
|
|
|||
| ### Vertical | |||
|
|
|||
| To adapt keyboard navigation (e.g. arrow keys) to use a vertical orientation, set `orientation="vertical"` on the `Tabs` component. | |||
There was a problem hiding this comment.
Let's make this more informative, and also clarify that it's a "must" for a11y purposes.
Suggested change
| To adapt keyboard navigation (e.g. arrow keys) to use a vertical orientation, set `orientation="vertical"` on the `Tabs` component. | |
| Tab components can be arranged vertically as well as horizontally. | |
| When vertical, you must set `orientation="vertical"` on the `<Tabs />` component so the user can navigate with the up and down arrow keys (rather than the default left-to-right behavior for horizontal tabs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31111
preview: https://deploy-preview-37292--material-ui.netlify.app/base/react-tabs/#vertical