[material-ui][ListItemText] Add slots and slotProps - #44571
Merged
Conversation
sai6855
marked this pull request as draft
November 27, 2024 10:26
sai6855
changed the title
slots and slotPropsslots and slotProps
sai6855
changed the title
slots and slotPropsslots and slotProps
sai6855
added
docs
Netlify deploy previewListItemText: parsed: +2.84% , gzip: +2.57% Bundle size reportDetails of bundle changes (Toolpad) |
siriwatknp
reviewed
Dec 2, 2024
| export interface ListItemTextSlots { | ||
| /** | ||
| * The component that renders the main content. | ||
| * @default span |
Member
There was a problem hiding this comment.
Suggested change
| * @default span | |
| * The component that renders the primary slot. | |
| * @default Typography |
sai6855
marked this pull request as ready for review
December 2, 2024 09:12
siriwatknp
reviewed
Dec 2, 2024
Comment on lines
+21
to
+26
| export type ListItemTextSlotsAndSlotProps = CreateSlotsAndSlotProps< | ||
| ListItemTextSlots, | ||
| { | ||
| primary: SlotProps<React.ElementType<HTMLSpanElement>, {}, ListItemTextOwnerState>; | ||
| secondary: SlotProps<React.ElementType<HTMLParagraphElement>, {}, ListItemTextOwnerState>; | ||
| } |
Member
There was a problem hiding this comment.
I think it's nice to add description to the slotProps with links to the API page in case it's a another component. The DX is a lot better.
siriwatknp
reviewed
Dec 2, 2024
…rial-ui into slots-listitem-text
siriwatknp
reviewed
Dec 4, 2024
siriwatknp
force-pushed
the
slots-listitem-text
branch
from
December 6, 2024 03:52
2803c54 to
d1bdbcb
Compare
38 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #41281
Not sure about about argos failure, same issue can be seen in other PR's as well
example: https://app.argos-ci.com/mui/material-ui/builds/34017