[test] Fix react@18/next nightly CI matrix#48635
Draft
Janpot wants to merge 1 commit into
Draft
Conversation
Deploy previewhttps://deploy-preview-48635--material-ui.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
- test_regressions: skip the 'A11y results committed?' git-clean check on the react@17/18/next jobs, which pin React via package-overrides and so dirty package.json/pnpm-lock.yaml. - ListItem: type slotProps.root as SlotProps so it accepts a callback (matches the conformance slotProps-callback test); regenerated propTypes. - Tab: skip the theme-wrapping conformance tests. They wrap the element in a ThemeProvider, which Tabs then clones with Tab-internal props (fullWidth, indicator, …), tripping ThemeProvider's exactProp under React 18. - useValueAsRef: read the ref after each render settles so React 18 StrictMode's mount/remount doesn't skew the identity comparison.
Janpot
force-pushed
the
worktree-ci-react-matrix-fixes
branch
from
d624e6d to
70d5444
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
react@18andreact@nextnightly CI matrix, which was red across the unit, browser, and visual-regression jobs onmaster. Each failure is React-version-specific, so they don't surface on the default (React 19 stable) PR runs.test_regressions(react@17/18/next) — the "A11y results committed?" step ran an unscopedgit diff --exit-code, but these jobs pin React viapackage-overrides, which rewritespackage.json/pnpm-lock.yamland tripped the check. The a11y results are React-version independent, so the check now only runs on the default React job.ListItem—slotProps.rootwas typed as plainHTMLAttributes, so the generated propType wasPropTypes.objectand rejected the callback form that the conformanceslotProps.roottest passes (a warning under React 18, which still validates propTypes). Typed it asSlotPropslike the other slots and regenerated propTypes.Tab—Tabmust render as a direct child ofTabs, which injects state into its children viacloneElement(fullWidth,indicator,selected, …). The theme-wrapping conformance tests wrap the element in aThemeProvider, soTabsclones the provider with those props and trips itsexactPropcheck under React 18. Unlike other nested components (Step,MenuItem, …) which pass parent state via context,Tabsis the odd one out, so these conformance checks don't apply toTaband are skipped.useValueAsRef— the ref-identity test latched its first reference during the initial render, capturing the transient object that React 18 StrictMode discards on its mount/remount. It now reads the ref after each render settles.Verified locally against both React 18.3.1 and React 19.2.6 (node and chromium).
Note: the
InitColorSchemeScriptreact@nextfailures from the same nightly are already handled by #48604.