Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Bump monorepo #10129

Merged
merged 2 commits into from
Aug 24, 2023
Merged

[core] Bump monorepo #10129

merged 2 commits into from
Aug 24, 2023

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Aug 24, 2023

Benefits from the merged mui/material-ui#38579 and #10026 to properly generate plan icon link titles

@LukasTy LukasTy added the core Infrastructure work going on behind the scenes label Aug 24, 2023
@LukasTy LukasTy self-assigned this Aug 24, 2023
@mui-bot
Copy link

mui-bot commented Aug 24, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-10129--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms -185 19.8 -185 -106.06 74.027
Sort 100k rows ms 789.3 1,475.1 1,415 1,257.64 250.196
Select 100k rows ms 601.8 847 716.8 707.6 82.145
Deselect 100k rows ms 147.6 291.4 201.7 200.96 51.267

Generated by 🚫 dangerJS against d064a8a

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -419,7 +419,7 @@ export default function ChartDemoPropsForm<T extends { [k: string]: any } = {}>(
{resolvedValue}
</Box>
{/* void */}
<Box />
<div />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is their a reason?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, after the monorepo bump, we have a new rule, which does not allow using empty Box elements: mui/material-ui#38461

@LukasTy LukasTy merged commit 22e1c8d into mui:master Aug 24, 2023
17 checks passed
@LukasTy LukasTy deleted the bump-monorepo branch August 24, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants