New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #4

Merged
merged 3 commits into from May 5, 2015

Conversation

Projects
None yet
2 participants
@adherzog
Contributor

adherzog commented Apr 29, 2015

This PR adds additional tests, and improves overall test coverage from 88.8% to 93.3%.

There are two changes to the module itself, in response to specific warnings appearing when creating objects with particularly egregious arguments.

The first change removes the warning "Illegal hexadecimal digit 'Y' ignored" when passing a mask like '0xY', and ensures that only valid hex characters are allowed.

The second change removes the warning "Use of uninitialized value in bitwise and (&)", by ensuring that $bits is defined and valid before using it to modify $ibase.

adherzog added some commits Apr 29, 2015

Restrict matching to valid hex characters.
This removes the warning "Illegal hexadecimal digit 'Y' ignored" when
passing a mask like '0xY', and ensures that only valid hex characters
are allowed.
Validate $bits before using it for $ibase.
This removes the warning "Use of uninitialized value in bitwise and
(&)", by ensuring that $bits is defined and valid before using it to
modify $ibase.

@muir muir merged commit 6dd8a12 into muir:master May 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment