New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving open RTCPAN Bugs #7

Merged
merged 4 commits into from Oct 30, 2015

Conversation

Projects
None yet
2 participants
@brainbuz
Contributor

brainbuz commented Sep 26, 2015

Neil Bowers gave me Time::ParseDate for my September pull request challenge.

I've addressed all 3 outstanding bugs from rtcpan.

@brainbuz

This comment has been minimized.

Show comment
Hide comment
@brainbuz

brainbuz Sep 29, 2015

Contributor

I posted an unofficial trial release to cpan, the changes will also require adding Time::Piece to the dependency list to pass with 5.6, but other than that everything has passed, but there don't seem to be any reports yet from Windows smokers.

You can view my reports at:
http://cpantesters.org/author/B/BRAINBUZ.html#Time-Modules
http://matrix.cpantesters.org/?dist=Time-Modules+2015.09251-TRIAL

Contributor

brainbuz commented Sep 29, 2015

I posted an unofficial trial release to cpan, the changes will also require adding Time::Piece to the dependency list to pass with 5.6, but other than that everything has passed, but there don't seem to be any reports yet from Windows smokers.

You can view my reports at:
http://cpantesters.org/author/B/BRAINBUZ.html#Time-Modules
http://matrix.cpantesters.org/?dist=Time-Modules+2015.09251-TRIAL

muir added a commit that referenced this pull request Oct 30, 2015

Merge pull request #7 from brainbuz/master
Resolving open RTCPAN Bugs

@muir muir merged commit b3c8798 into muir:master Oct 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brainbuz

This comment has been minimized.

Show comment
Hide comment
@brainbuz

brainbuz Oct 31, 2015

Contributor

There were still no test reports from the cpan testers for my test release on windows. so I took some time to investigate further (which required fixing Perl on my Windows box). the old version of the module currently up on cpan installs successfully via cpanm in strawberry perl, but my test release does not. tests dealing specifically with the time offset issue are the ones failing. Since I stepped up on for the pull request this I'm willing to continue working on the problem.

I think it would be desirable to at least partially support this module on Windows. I can go back and review my merging of the patch submitted for windows as a first step.

Contributor

brainbuz commented Oct 31, 2015

There were still no test reports from the cpan testers for my test release on windows. so I took some time to investigate further (which required fixing Perl on my Windows box). the old version of the module currently up on cpan installs successfully via cpanm in strawberry perl, but my test release does not. tests dealing specifically with the time offset issue are the ones failing. Since I stepped up on for the pull request this I'm willing to continue working on the problem.

I think it would be desirable to at least partially support this module on Windows. I can go back and review my merging of the patch submitted for windows as a first step.

@muir

This comment has been minimized.

Show comment
Hide comment
@muir

muir Oct 31, 2015

Owner

I intended to update it but ran into a non-related glitch that delayed me.
I'll get it done tomorrow. Thank you for the patches.

On Sat, Oct 31, 2015 at 1:22 PM, John Karr notifications@github.com wrote:

There were still no test reports from the cpan testers for my test release
on windows. so I took some time to investigate further (which required
fixing Perl on my Windows box). the old version of the module currently up
on cpan installs successfully via cpanm in strawberry perl, but my test
release does not. tests dealing specifically with the time offset issue are
the ones failing. Since I stepped up on for the pull request this I'm
willing to continue working on the problem.

I think it would be desirable to at least partially support this module on
Windows. I can go back and review my merging of the patch submitted for
windows as a first step.


Reply to this email directly or view it on GitHub
#7 (comment).

Owner

muir commented Oct 31, 2015

I intended to update it but ran into a non-related glitch that delayed me.
I'll get it done tomorrow. Thank you for the patches.

On Sat, Oct 31, 2015 at 1:22 PM, John Karr notifications@github.com wrote:

There were still no test reports from the cpan testers for my test release
on windows. so I took some time to investigate further (which required
fixing Perl on my Windows box). the old version of the module currently up
on cpan installs successfully via cpanm in strawberry perl, but my test
release does not. tests dealing specifically with the time offset issue are
the ones failing. Since I stepped up on for the pull request this I'm
willing to continue working on the problem.

I think it would be desirable to at least partially support this module on
Windows. I can go back and review my merging of the patch submitted for
windows as a first step.


Reply to this email directly or view it on GitHub
#7 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment