Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time.Duration & flag.Value #8

Merged
merged 1 commit into from Dec 29, 2021
Merged

time.Duration & flag.Value #8

merged 1 commit into from Dec 29, 2021

Conversation

muir
Copy link
Owner

@muir muir commented Dec 29, 2021

Add support for registering unpackers and use that to support time.Duration
Add support for unpacking into flag.Value

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #8 (3915e74) into main (9edbedf) will decrease coverage by 3.10%.
The diff coverage is 56.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   80.72%   77.62%   -3.11%     
==========================================
  Files           3        4       +1     
  Lines         249      286      +37     
==========================================
+ Hits          201      222      +21     
- Misses         31       39       +8     
- Partials       17       25       +8     
Impacted Files Coverage Δ
setters.go 29.41% <29.41%> (ø)
unpack.go 74.10% <80.00%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9edbedf...3915e74. Read the comment docs.

@muir muir merged commit bbfdc44 into main Dec 29, 2021
22 of 25 checks passed
@muir muir deleted the duration branch Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants