Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout config options #772

Merged
merged 1 commit into from Oct 13, 2020
Merged

Add timeout config options #772

merged 1 commit into from Oct 13, 2020

Conversation

AlexDenisov
Copy link
Member

No description provided.

jnohlgard
jnohlgard suggested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is something that I have use of for some of my test cases. There is already a default timeout constant which could be used as the default value in cli options too, to avoid repeating the same literal twice.

jnohlgard
jnohlgard approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AlexDenisov AlexDenisov merged commit 06196dd into master Oct 13, 2020
@AlexDenisov AlexDenisov deleted the config-timeout branch October 13, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnohlgard jnohlgard jnohlgard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexDenisov @jnohlgard