Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fish shell completions #1860

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Add fish shell completions #1860

merged 1 commit into from
Jun 26, 2020

Conversation

cljoly
Copy link
Contributor

@cljoly cljoly commented Jun 20, 2020

Generate fish shell completions at build time. Empower fish users with
completions.

Completions are copied in the recommended directory.

Describe what this PR changes. Why this is wanted. And, if needed, how it does it.

Git checklist:


This change is Reviewable

@faern faern self-requested a review June 24, 2020 08:48
Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good! Thank you for this contribution.

I have some nitpicks about the changelog that I would like you to fix.

The git history is also currently in a form we can't merge. We do not merge master into feature branches and then back. Please rebase the feature branch on latest master and squash commits in such a way that the feature branch has no merge commits. This small feature can preferably just be a single commit.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Generate fish shell completions at build time. Empower fish users with
completions.

Completions are copied in the [recommended directory](https://fishshell.com/docs/current/#where-to-put-completions)
@cljoly
Copy link
Contributor Author

cljoly commented Jun 24, 2020


CHANGELOG.md, line 28 at r2 (raw file):

Previously, faern (Linus Färnstrand) wrote…

My bad! It's for two platforms. So keeping it under the generic header is fine. It could be extended to say "on Linux and macOS" but that's just nitpick. I don't think fish exists for Windows anyway? Resolved.

Yes, no windows support for fish: fish-shell/fish-shell#319

@cljoly cljoly requested a review from faern June 24, 2020 19:23
@cljoly
Copy link
Contributor Author

cljoly commented Jun 24, 2020

Thanks for your review. I think I have addressed your comments.

@faern
Copy link
Member

faern commented Jun 25, 2020

Thank you very much. I will merge this asap.

@cljoly
Copy link
Contributor Author

cljoly commented Jun 25, 2020

Awesome!

@faern faern merged commit 143208d into mullvad:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants