Add fish shell completions - #1860
Conversation
faern
left a comment
There was a problem hiding this comment.
The code changes look good! Thank you for this contribution.
I have some nitpicks about the changelog that I would like you to fix.
The git history is also currently in a form we can't merge. We do not merge master into feature branches and then back. Please rebase the feature branch on latest master and squash commits in such a way that the feature branch has no merge commits. This small feature can preferably just be a single commit.
Generate fish shell completions at build time. Empower fish users with completions. Completions are copied in the [recommended directory](https://fishshell.com/docs/current/#where-to-put-completions)
|
CHANGELOG.md, line 28 at r2 (raw file): Previously, faern (Linus Färnstrand) wrote…
Yes, no windows support for fish: fish-shell/fish-shell#319 |
|
Thanks for your review. I think I have addressed your comments. |
|
Thank you very much. I will merge this asap. |
|
Awesome! |
Generate fish shell completions at build time. Empower fish users with
completions.
Completions are copied in the recommended directory.
Describe what this PR changes. Why this is wanted. And, if needed, how it does it.
Git checklist:
CHANGELOG.mdunder the[Unreleased]header.This change is