Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert email and phone to MultaccItem #32

Merged
merged 1 commit into from Mar 7, 2020
Merged

Convert email and phone to MultaccItem #32

merged 1 commit into from Mar 7, 2020

Conversation

@TortoiseWrath
Copy link
Contributor

TortoiseWrath commented Mar 7, 2020

Closes #27.

  • MultaccContact now copies identifier to clientKey (see #14)
  • Adds Phone and Email types to the MultaccItemType enum
  • Adds EmailItem and PhoneItem classes
    • fromItem constructors convert Item objects from contacts_service
      to these MultaccItem implementations
  • Populates multaccItems with PhoneItem and EmailItem instances when
    constructing a MultaccContact from a Contact
  • Adds TODOs to do the same for addresses, SIP, and IM
  • Increase Dart version to 2.3.0 to enable spread operator
  • Whitespace changes in twitter.dart thanks to Android Studio
Closes #27.
* MultaccContact now copies identifier to clientKey (see #14)
* Adds Phone and Email types to the MultaccItemType enum
* Adds EmailItem and PhoneItem classes
    * fromItem constructors convert Item objects from contacts_service
      to these MultaccItem implementations
* Populates multaccItems with PhoneItem and EmailItem instances when
  constructing a MultaccContact from a Contact
* Adds TODOs to do the same for addresses, SIP, and IM
* Increase Dart version to 2.3.0 to enable spread operator
* Whitespace changes in twitter.dart thanks to Android Studio
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 7, 2020

Implement email launching

// @todo Implement email launching
}
bool isLaunchable() => true;
}


This comment was generated by todo based on a todo comment in 285962a in #32. cc @multacc.
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 7, 2020

Frontend team should add something like getIcon to MultaccItem

// @todo Frontend team should add something like getIcon to MultaccItem
}
// To maintain the relationship between type and enum index, never remove things from this enum and always add new
// things at the end pls kthx
enum MultaccItemType {


This comment was generated by todo based on a todo comment in 285962a in #32. cc @multacc.
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 7, 2020

Implement dogecoin

Dogecoin, // @todo Implement dogecoin
Phone,
Email
}


This comment was generated by todo based on a todo comment in 285962a in #32. cc @multacc.
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 7, 2020

Format phone numbers

String getHumanReadableValue() => phone; // @ todo Format phone numbers
MultaccItemType getType() => MultaccItemType.Phone;
void launchApp() {
// @todo Implement phone launching


This comment was generated by todo based on a todo comment in 285962a in #32. cc @multacc.
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 7, 2020

Implement phone launching

// @todo Implement phone launching
}
bool isLaunchable() => true;
}


This comment was generated by todo based on a todo comment in 285962a in #32. cc @multacc.
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 7, 2020

Use a field other than identifier for clientKey (#26)

// @todo Use a field other than identifier for clientKey (#26)
clientKey = identifier; // Key in client-side database
serverKey = null; // Key in server-side database
multaccItems = [
...phones.map((item) => PhoneItem.fromItem(item)), // create PhoneItems from phone Items
...emails.map((item) => EmailItem.fromItem(item)), // create EmailItems from email Items


This comment was generated by todo based on a todo comment in 285962a in #32. cc @multacc.
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 7, 2020

Convert addresses to Multacc items

https://github.com/multacc/multacc/blob/285962a85b2262b6a9ecc347fb39abfaa74925e7/lib/pages/contacts/contact_model.dart#L40-L39


This comment was generated by todo based on a todo comment in 285962a in #32. cc @multacc.
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 7, 2020

Convert IM to Multacc items

https://github.com/multacc/multacc/blob/285962a85b2262b6a9ecc347fb39abfaa74925e7/lib/pages/contacts/contact_model.dart#L41-L39


This comment was generated by todo based on a todo comment in 285962a in #32. cc @multacc.
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 7, 2020

Convert SIP to Multacc items

https://github.com/multacc/multacc/blob/285962a85b2262b6a9ecc347fb39abfaa74925e7/lib/pages/contacts/contact_model.dart#L42-L39


This comment was generated by todo based on a todo comment in 285962a in #32. cc @multacc.
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 7, 2020

Pull multacc items from database when loading a contact

https://github.com/multacc/multacc/blob/285962a85b2262b6a9ecc347fb39abfaa74925e7/lib/pages/contacts/contact_model.dart#L43-L39


This comment was generated by todo based on a todo comment in 285962a in #32. cc @multacc.
Copy link
Contributor

mayank99 left a comment

Love the spread operator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.