Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local db #56

Merged
merged 5 commits into from Mar 12, 2020
Merged

Local db #56

merged 5 commits into from Mar 12, 2020

Conversation

@micah-white
Copy link
Contributor

micah-white commented Mar 12, 2020

No description provided.

@TortoiseWrath

This comment has been minimized.

Copy link
Member

TortoiseWrath commented Mar 12, 2020

First note: You should link issue #21 to this PR since it closes that issue when merged

lib/items/item.dart Outdated Show resolved Hide resolved
@TortoiseWrath TortoiseWrath linked an issue that may be closed by this pull request Mar 12, 2020
@mayank99 mayank99 added this to In progress in multacc via automation Mar 12, 2020
@TortoiseWrath TortoiseWrath self-requested a review Mar 12, 2020
@mayank99 mayank99 removed this from In progress in multacc Mar 12, 2020
Copy link
Member

TortoiseWrath left a comment

Will add item id to the json later as that is the easiest way to store it the way you've set up the database.

lib/database/database_interface.dart Outdated Show resolved Hide resolved
lib/database/database_interface.dart Outdated Show resolved Hide resolved
lib/database/database_interface.dart Outdated Show resolved Hide resolved
lib/database/database_interface.dart Outdated Show resolved Hide resolved
lib/database/database_interface.dart Outdated Show resolved Hide resolved
lib/main.dart Outdated Show resolved Hide resolved
lib/main.dart Outdated Show resolved Hide resolved
lib/main.dart Outdated Show resolved Hide resolved
lib/pages/contacts/contacts_data.dart Show resolved Hide resolved
lib/database/database_interface.dart Outdated Show resolved Hide resolved
Co-Authored-By: Sean Gillen <sdgillen@crimson.ua.edu>
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 12, 2020

Store the item id in the database

// @todo Store the item id in the database
return serializedItems.cast<String>().map((json) => MultaccItem.fromDB(null /* id */, jsonDecode(json)));
}
}


This comment was generated by todo based on a todo comment in 86b89a6 in #56.
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 12, 2020

Remove dummy contacts when database is known to work

multacc/lib/main.dart

Lines 47 to 51 in 86b89a6

dbi.addDummyContacts(); // @todo Remove dummy contacts when database is known to work
// fetch groupme messages in background if authorized
final chatsData = ChatsData();
services.registerSingleton(chatsData);


This comment was generated by todo based on a todo comment in 86b89a6 in #56.
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 12, 2020

Store the item id in the database

// @todo Store the item id in the database
return serializedItems.cast<String>().map((json) => MultaccItem.fromDB(null /* id */, jsonDecode(json)));
}
}


This comment was generated by todo based on a todo comment in 86b89a6 in #56.
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 12, 2020

Remove dummy contacts when database is known to work

multacc/lib/main.dart

Lines 47 to 51 in 86b89a6

dbi.addDummyContacts(); // @todo Remove dummy contacts when database is known to work
// fetch groupme messages in background if authorized
final chatsData = ChatsData();
services.registerSingleton(chatsData);


This comment was generated by todo based on a todo comment in 86b89a6 in #56.
@mayank99 mayank99 merged commit 87c7f5f into master Mar 12, 2020
0 of 2 checks passed
0 of 2 checks passed
build build
Details
build build
Details
@mayank99 mayank99 deleted the local-db branch Mar 12, 2020
TortoiseWrath added a commit that referenced this pull request Mar 12, 2020
Fix failing build from #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.