Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contact details page #57

Merged
merged 3 commits into from Mar 12, 2020
Merged

Improve contact details page #57

merged 3 commits into from Mar 12, 2020

Conversation

@mayank99
Copy link
Contributor

mayank99 commented Mar 12, 2020

  • Replaced draggable sheet with new package to fix snapping
  • Added search support for contacts
  • Added avatars with fallback icon
  • Implemented launching phone and email
  • Added settings page (with a selection for preferred phone app)
  • Added toSet() to prevent duplicating phone numbers
  • Lots of refactoring and cleanup 馃嵏

Closes #6, #33, #35, #50, #53

- Replaced draggable sheet with new package to fix snapping
- Added search support for contacts
- Added avatars with fallback icon
- Implemented launching phone and email
- Added settings page (with a selection for preferred phone app)
- Added toSet() to prevent duplicating phone numbers
- Lots of refactoring and cleanup :D
@mayank99 mayank99 requested a review from TortoiseWrath Mar 12, 2020
@mayank99 mayank99 added this to In progress in multacc via automation Mar 12, 2020
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 12, 2020

Add support for searching chats too

/// @todo Add support for searching chats too
class BottomBarSearchDelegate extends SearchDelegate<String> {
final ContactsData contactsData = services.get<ContactsData>();
@override
ThemeData appBarTheme(BuildContext context) {


This comment was generated by todo based on a todo comment in 31f5368 in #57.
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 12, 2020

Implement conversation screen

// onTap: () => showDraggableSheet(context, Center(child: Text('DM'))), // @todo Implement conversation screen
);
}


This comment was generated by todo based on a todo comment in 31f5368 in #57.
@todo

This comment has been minimized.

Copy link

todo bot commented Mar 12, 2020

Fix ContactDetails height for scrolling

height: MediaQuery.of(context).size.height / 1.1, // @todo Fix ContactDetails height for scrolling
child: Column(
children: <Widget>[
Avatars.buildContactAvatar(memoryImage: contact.avatar, radius: 40.0),
_buildName(),
_buildShortcutsRow(),


This comment was generated by todo based on a todo comment in 31f5368 in #57.
lib/items/phone.dart Outdated Show resolved Hide resolved
lib/pages/contacts/contact_model.dart Show resolved Hide resolved
mayank99 and others added 2 commits Mar 12, 2020
Co-Authored-By: Sean Gillen <sdgillen@crimson.ua.edu>
@mayank99 mayank99 merged commit 6755d5b into master Mar 12, 2020
1 check failed
1 check failed
build build
Details
multacc automation moved this from In progress to Done Mar 12, 2020
@mayank99 mayank99 deleted the contact-details-page branch Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.