Add isValid method to Multibase class#39
Merged
Conversation
Contributor
Author
|
DRAFT; wait let me first see if this actually even compiles... 🤣 ... and then I'll change the initial "naive" implementation of the method. |
Starting point of multiformats#38, generated by GitHub Copilot Workspace AI.
vorburger
force-pushed
the
add-isvalid-method
branch
from
9872cbe to
5d8615a
Compare
Contributor
Author
Huh, how weird that GitHub Copilot Workspace AI seemingly randomly decided to change test data - I've undone that. |
ianopolous
approved these changes
Feb 26, 2025
PS: Humans are still smarter than AI... for now! ;-)
Contributor
Author
|
@ianopolous voilà! Please re-view, there is a 2nd commit here now - I'm not sure that you've seen that as well? If LGTM, feel free to merge at your convenience - this is (now) final, from my side. |
ianopolous
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting point of #38,
generated by GitHub Copilot Workspace AI.