fix: use @chainsafe/is-ip #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Will need a follow up PR to replace |
Member
|
Thanks! |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 29, 2022
## [11.0.6](v11.0.5...v11.0.6) (2022-10-29) ### Bug Fixes * use @chainsafe/is-ip ([#280](#280)) ([40124ff](40124ff))
|
🎉 This PR is included in version 11.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
is-ip5.0.0 is significantly slower than 4.0.0. This is due to adding protection against regex DoS.It does so by wrapping its regex calls in
node:vmapis with a timeout.Although the resulting code is protected against regex DoS, its also ~6000x slower, so slow that it shows up with non-negligible time in Lodestar cpu profiles.
Solution:
Replace
is-ipdependency with@chainsafe/is-ip.@chainsafe/is-ipis a drop-in replacement foris-ipthat is a transliteration of some of rust's std net code - this.It's ~300x faster for valid IPv4 values, ~30x faster for valid IPv6 values than
is-ip5.0.0. And it's not vulnerable to regex DoS because it doesn't use regex, rather it uses a simple parser built just for the job of parsing IP addr strings.See discussion: