From a9eecf6d8005a8e517409071c66f71fc36e0cacf Mon Sep 17 00:00:00 2001 From: Roni Choudhury Date: Fri, 21 Feb 2020 13:53:23 -0500 Subject: [PATCH 1/2] Add documentation links to the About panel This commit also introduces a "safe" external link component. --- client/src/components/AExt.vue | 18 ++++++++++++++++++ client/src/components/AboutDialog.vue | 12 ++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 client/src/components/AExt.vue diff --git a/client/src/components/AExt.vue b/client/src/components/AExt.vue new file mode 100644 index 00000000..d16227f6 --- /dev/null +++ b/client/src/components/AExt.vue @@ -0,0 +1,18 @@ + + + diff --git a/client/src/components/AboutDialog.vue b/client/src/components/AboutDialog.vue index fa98bb5d..e41531ce 100644 --- a/client/src/components/AboutDialog.vue +++ b/client/src/components/AboutDialog.vue @@ -34,6 +34,12 @@ noreferrer">GitHub. + + Check out the Multinet project documentation, or + the API docs. + + import Vue from 'vue'; +import AExt from '@/components/AExt.vue'; + declare const GIT_SHA: string; export default Vue.extend({ + components: { + AExt, + }, + data() { return { dialog: false, From c9997f9e686d0a126c76f7115fc4d7d4f11027fc Mon Sep 17 00:00:00 2001 From: Roni Choudhury Date: Fri, 21 Feb 2020 13:55:56 -0500 Subject: [PATCH 2/2] Fix up other external links The other links were intended to be externally opening links (as evidenced by the `rel` attribute on them) but the `target="_blank"` bit was missing on some of them. All have been updated to use the AExt component. --- client/src/components/AboutDialog.vue | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/client/src/components/AboutDialog.vue b/client/src/components/AboutDialog.vue index e41531ce..4a7cba48 100644 --- a/client/src/components/AboutDialog.vue +++ b/client/src/components/AboutDialog.vue @@ -27,11 +27,9 @@ - Multinet is a system for storing and processing multivariate networks. Learn more and explore the code - at GitHub. + Multinet is a system for storing and processing multivariate networks. Learn more and explore the code + at GitHub. @@ -45,7 +43,7 @@ class="px-4 pt-4 pb-1" > This instance of Multinet was built from Git SHA - {{gitSha.slice(0, 6)}}. + {{gitSha.slice(0, 6)}}.