Resolve errors and warnings in vendor

Author: botder

vendor/bcrypt/crypt_blowfish.c

@@ -896,8 +896,8 @@ char *_crypt_gensalt_blowfish_rn(const char *prefix, unsigned long count,
 	output[1] = '2';
 	output[2] = prefix[2];
 	output[3] = '$';
-	output[4] = '0' + count / 10;
-	output[5] = '0' + count % 10;
+	output[4] = (char)('0' + count / 10);
+	output[5] = (char)('0' + count % 10);
 	output[6] = '$';
 
 	BF_encode(&output[7], (const BF_word *)input, 16);

vendor/detours/4.0.1/src/creatwth.cpp

@@ -949,14 +949,17 @@ VOID CALLBACK DetourFinishHelperProcess(_In_ HWND,
 {
     LPCSTR * rlpDlls = NULL;
     DWORD Result = 9900;
+    DWORD cSize = 0;
+    DWORD cOffset = 0;
+    HANDLE hProcess = NULL;
 
     if (s_pHelper == NULL) {
         DETOUR_TRACE(("DetourFinishHelperProcess called with s_pHelper = NULL.\n"));
         Result = 9905;
         goto Cleanup;
     }
 
-    HANDLE hProcess = OpenProcess(PROCESS_ALL_ACCESS, FALSE, s_pHelper->pid);
+    hProcess = OpenProcess(PROCESS_ALL_ACCESS, FALSE, s_pHelper->pid);
     if (hProcess == NULL) {
         DETOUR_TRACE(("OpenProcess(pid=%d) failed: %d\n",
                       s_pHelper->pid, GetLastError()));
@@ -965,8 +968,8 @@ VOID CALLBACK DetourFinishHelperProcess(_In_ HWND,
     }
 
     rlpDlls = new NOTHROW LPCSTR [s_pHelper->nDlls];
-    DWORD cSize = s_pHelper->cb - sizeof(DETOUR_EXE_HELPER);
-    DWORD cOffset = 0;
+    cSize = s_pHelper->cb - sizeof(DETOUR_EXE_HELPER);
+    cOffset = 0;
     for (DWORD n = 0; n < s_pHelper->nDlls; n++) {
         size_t cchDest = 0;
         HRESULT hr = StringCchLengthA(&s_pHelper->rDlls[cOffset], cSize - cOffset, &cchDest);
@@ -1029,6 +1032,8 @@ BOOL WINAPI AllocExeHelper(_Out_ PDETOUR_EXE_HELPER *pHelper,
 {
     PDETOUR_EXE_HELPER Helper = NULL;
     BOOL Result = FALSE;
+    _Field_range_(0, cSize - 4) DWORD cOffset = 0;
+    DWORD cSize = 4;
 
     if (pHelper == NULL) {
         goto Cleanup;
@@ -1040,7 +1045,6 @@ BOOL WINAPI AllocExeHelper(_Out_ PDETOUR_EXE_HELPER *pHelper,
         goto Cleanup;
     }
 
-    DWORD cSize = 4;
     for (DWORD n = 0; n < nDlls; n++) {
         HRESULT hr;
         size_t cchDest = 0;
@@ -1061,8 +1065,7 @@ BOOL WINAPI AllocExeHelper(_Out_ PDETOUR_EXE_HELPER *pHelper,
     Helper->cb = sizeof(DETOUR_EXE_HELPER) + cSize;
     Helper->pid = dwTargetPid;
     Helper->nDlls = nDlls;
-
-    _Field_range_(0, cSize - 4) DWORD cOffset = 0;
+    
     for (DWORD n = 0; n < nDlls; n++) {
         HRESULT hr;
         size_t cchDest = 0;
@@ -1154,6 +1157,7 @@ BOOL WINAPI DetourProcessViaHelperDllsA(_In_ DWORD dwTargetPid,
     CHAR szCommand[MAX_PATH];
     PDETOUR_EXE_HELPER helper = NULL;
     HRESULT hr;
+    DWORD nLen = 0;
 
     DETOUR_TRACE(("DetourProcessViaHelperDlls(pid=%d,dlls=%d)\n", dwTargetPid, nDlls));
     if (nDlls < 1 || nDlls > 4096) {
@@ -1164,7 +1168,7 @@ BOOL WINAPI DetourProcessViaHelperDllsA(_In_ DWORD dwTargetPid,
         goto Cleanup;
     }
 
-    DWORD nLen = GetEnvironmentVariableA("WINDIR", szExe, ARRAYSIZE(szExe));
+    nLen = GetEnvironmentVariableA("WINDIR", szExe, ARRAYSIZE(szExe));
     if (nLen == 0 || nLen >= ARRAYSIZE(szExe)) {
         goto Cleanup;
     }
@@ -1250,6 +1254,7 @@ BOOL WINAPI DetourProcessViaHelperDllsW(_In_ DWORD dwTargetPid,
     WCHAR szCommand[MAX_PATH];
     PDETOUR_EXE_HELPER helper = NULL;
     HRESULT hr;
+    DWORD nLen = 0;
 
     DETOUR_TRACE(("DetourProcessViaHelperDlls(pid=%d,dlls=%d)\n", dwTargetPid, nDlls));
     if (nDlls < 1 || nDlls > 4096) {
@@ -1260,7 +1265,7 @@ BOOL WINAPI DetourProcessViaHelperDllsW(_In_ DWORD dwTargetPid,
         goto Cleanup;
     }
 
-    DWORD nLen = GetEnvironmentVariableW(L"WINDIR", szExe, ARRAYSIZE(szExe));
+    nLen = GetEnvironmentVariableW(L"WINDIR", szExe, ARRAYSIZE(szExe));
     if (nLen == 0 || nLen >= ARRAYSIZE(szExe)) {
         goto Cleanup;
     }

vendor/freetype/src/gxvalid/gxvmort2.c

@@ -192,8 +192,8 @@
                      offset, optdata->ligatureTable - offset * 2 ));
 
         GXV_SET_ERR_IF_PARANOID( FT_INVALID_OFFSET );
-      } else if ( offset * 2 >
-                  optdata->ligatureTable + optdata->ligatureTable_length )
+      } else if ( offset * 2u >
+                  (FT_ULong)( optdata->ligatureTable + optdata->ligatureTable_length ) )
       {
         GXV_TRACE(( "too long offset 0x%08lx:"
                     " 2 x offset > ligatureTable + ligatureTable_length"

vendor/json-c/premake5.lua

@@ -2,6 +2,11 @@ project "json-c"
 	language "C++"
 	kind "StaticLib"
 	targetname "json-c"
+	disablewarnings {
+		"4244", -- warning C4244: '=': conversion from '?' to '?', possible loss of data
+		"4018", -- warning C4018: '<': signed/unsigned mismatch
+		"4996", -- use of symbol with __declspec(deprecated)
+	}
 
 	includedirs { "." }
 	defines { "_LIB" }