Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bad numberstrings error instead of warn #1043

Open
qaisjp opened this issue Aug 7, 2019 · 1 comment
Open

Make bad numberstrings error instead of warn #1043

qaisjp opened this issue Aug 7, 2019 · 1 comment

Comments

@qaisjp
Copy link
Contributor

@qaisjp qaisjp commented Aug 7, 2019

See:

  • 51a2c78 "Fix bad numberstrings becoming 0", and
  • 73692fd "Make bad numberstrings warn instead of error"

This warning has been around since 1.5.3. I propose we make this an error in 1.6.

Please discuss and express your (dis)approval.

@qaisjp qaisjp added this to the 1.6 milestone Aug 18, 2019
@qaisjp qaisjp self-assigned this Aug 24, 2019
@qaisjp qaisjp removed this from the 1.5.8 milestone Apr 20, 2020
@qaisjp qaisjp added this to the 1.6 milestone Apr 20, 2020
@Pirulax
Copy link
Contributor

@Pirulax Pirulax commented May 30, 2020

I totally agree, there's no reason you would accept a bad number string, the user can explicitly check if its a bad numberstring or not. This may just cause misbehaving.

Also, Im pretty sure its rare you have a bad numberstring, but even if you do, you dont want it to modify anything into a possibly incorrect state.

Loading

qaisjp added a commit to qaisjp/mtasa-blue that referenced this issue May 30, 2020
qaisjp added a commit that referenced this issue May 31, 2020
@botder botder removed this from the Next Release milestone Feb 6, 2021
@botder botder added this to the Next Stage milestone Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants