Fix #2906: warpPedIntoVehicle causes a C++ runtime assertion failure #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lopezloo
changed the title
lopezloo
previously requested changes
Mar 9, 2023
|
That would be a good idea, I'll check it |
|
Or maybe just only to |
lopezloo
reviewed
Mar 9, 2023
lopezloo
reviewed
Mar 9, 2023
Damn, i mismatched the sign, Co-authored-by: lopez <7338099+lopezloo@users.noreply.github.com>
lopezloo
reviewed
Mar 9, 2023
Removed seat check in CPed.cpp
lopezloo
reviewed
Mar 9, 2023
Changed seat check to include values less than 0 and bigger than max passengers of a vehicle
|
It's still not possible to warp player to driver seat in trailer vehicles like it was before. Excluding seat 0 in |
Reformatted seat check. Now its possible to enter vehicle as a driver on trailers
lopezloo
reviewed
Mar 22, 2023
Increased readability Co-authored-by: lopez <7338099+lopezloo@users.noreply.github.com>
Fixed a typo
TracerDS
commented
Mar 23, 2023
patrikjuvonen
changed the title
lopezloo
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetMaxPassengers()returnsVEHICLE_PASSENGERS_UNDEFINEDif the amount of seat is undefined (this happens mainly on trailers). We can't warp player to a vehicle that doesn't have seats.By adding this fix, server wont crash from runtime exception when warping to a vehicle that doesnt have "enough" seats
In #2918 I fixed the issue but my repo and branch got corrupted and broke the whole PR (couldnt change the commit, add or remove files). Sorry