Add roll state to getPedMoveState while crouching or crawling #1635
Conversation
There was a problem hiding this comment.
At the moment this shows MOVEMENTSTATE_ROLL is activated when the ped is not actually rolling.
Steps to reproduce:
- Have fists (or any non-roll inducing weapon) equipped
- Hold right mouse and walk right/left, it shows roll while you're crawling
Furthermore: what are potential roll-preventing features in GTA/MTA? At least while you're in vehicle getPedMoveState is not available, but how about when you force an animation while crouched and try to roll? What other potential things can break this? I suggest try to break this check in as many ways as possible, thanks 👍
A test resource would be good too :)
Additionally, if you stop pressing any of the keys, the movement state returned is no longer roll, even though the roll animation is still playing.
This doesn't cover all cases it seems.
|
This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically. |
|
This draft pull request was closed because it has been marked stale for 30 days with no activity. |
Looks like the movement was declared but no code for It.