-
-
Notifications
You must be signed in to change notification settings - Fork 497
Move vendor/lua to a submodule #2112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks man.. I was getting very annoyed. |
|
I'll need to rebase this if we decide to merge it |
|
Let's not do this for Lua at this time. |
|
Let's do it now, what do you think? |
|
There is no benefits from this.
This has no sense. Submodules should be used for external or shared dependencies |
|
I would agree with TheNormalnij. The Lua version MTA uses is the internal thing. It is an inseparatable part of MTA that cannot be used in anywhere else. |
I made a PR in which Qais suggested me to use create a repo for our Lua vendor, and do modifications there instead.
This PR implements his idea.
It contains all previous commits back to 2008.
TODO: Test if everything works.