Skip to content

Conversation

@Pirulax
Copy link
Contributor

@Pirulax Pirulax commented Mar 8, 2021

I made a PR in which Qais suggested me to use create a repo for our Lua vendor, and do modifications there instead.
This PR implements his idea.
It contains all previous commits back to 2008.

TODO: Test if everything works.

@patrikjuvonen patrikjuvonen added the enhancement New feature or request label Mar 17, 2021
@Pirulax
Copy link
Contributor Author

Pirulax commented Mar 17, 2021

Thanks man.. I was getting very annoyed.

@Pirulax
Copy link
Contributor Author

Pirulax commented Mar 17, 2021

@Pirulax
Copy link
Contributor Author

Pirulax commented Mar 17, 2021

I'll need to rebase this if we decide to merge it

@Pirulax Pirulax marked this pull request as ready for review April 6, 2021 18:10
@patrikjuvonen
Copy link
Contributor

Let's not do this for Lua at this time.

@Pirulax Pirulax mentioned this pull request Dec 25, 2023
@Pirulax
Copy link
Contributor Author

Pirulax commented Dec 25, 2023

Let's do it now, what do you think?
We need submodules for Luau anyways.

@TheNormalnij
Copy link
Member

There is no benefits from this.
Submodules are good for external dependencies. For internal dependencies they make life harder.
Lua submodule just adds extra step in development:

  1. Create PR into lua repo
  2. Create PR into mta-blue remove with submodule update

This has no sense. Submodules should be used for external or shared dependencies

@tederis
Copy link
Member

tederis commented Dec 26, 2023

I would agree with TheNormalnij. The Lua version MTA uses is the internal thing. It is an inseparatable part of MTA that cannot be used in anywhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants