New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0009608: add bShallow argument for server-side water as well #240

Merged
merged 6 commits into from Aug 5, 2018

Conversation

Projects
5 participants
@patrikjuvonen
Collaborator

patrikjuvonen commented Jul 15, 2018

Mantis Bug Tracker issue:
9608

Summary:

  • Server-side code was missing the bShallow argument so it was never sent to clients;
  • Pretty small and simple fix, easy to test.
@qaisjp

This comment has been minimized.

Show comment
Hide comment
@qaisjp

qaisjp Jul 20, 2018

Member

Can someone confirm if this requires some more support for backwards compatbility?

Member

qaisjp commented Jul 20, 2018

Can someone confirm if this requires some more support for backwards compatbility?

@Jusonex

This comment has been minimized.

Show comment
Hide comment
@Jusonex

Jusonex Jul 21, 2018

Member

Yes, it does need version checks.

After incrementing the bitstream version in version.h, it needs to be wrapped in something like this (for both the server and the client):

if (bitStream.Version() > 0xBEAF)
{
   // Do your stuff
}
Member

Jusonex commented Jul 21, 2018

Yes, it does need version checks.

After incrementing the bitstream version in version.h, it needs to be wrapped in something like this (for both the server and the client):

if (bitStream.Version() > 0xBEAF)
{
   // Do your stuff
}

@Jusonex Jusonex added the question label Jul 21, 2018

@patrikjuvonen

This comment has been minimized.

Show comment
Hide comment
@patrikjuvonen

patrikjuvonen Jul 21, 2018

Collaborator

Thanks! I've now pushed a commit to increment the bitStream version and wrap the packet code to handle that.

Collaborator

patrikjuvonen commented Jul 21, 2018

Thanks! I've now pushed a commit to increment the bitStream version and wrap the packet code to handle that.

@Jusonex Jusonex removed the question label Jul 21, 2018

patrikjuvonen added some commits Jul 21, 2018

@qaisjp

qaisjp approved these changes Jul 23, 2018

@patrikjuvonen patrikjuvonen added this to the 1.5.6 milestone Aug 5, 2018

@patrikjuvonen patrikjuvonen added this to In progress in release/v1.5.6 via automation Aug 5, 2018

@qaisjp qaisjp merged commit 1321b53 into multitheftauto:master Aug 5, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP ready for review
Details

release/v1.5.6 automation moved this from In progress to Done Aug 5, 2018

@qaisjp qaisjp removed the pr:needs-testing label Aug 5, 2018

@patrikjuvonen patrikjuvonen deleted the patrikjuvonen:issue-9608 branch Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment