New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing guiEditGetMaxLength & guiEditIsMasked functions #255

Merged
merged 4 commits into from Jul 24, 2018

Conversation

Projects
4 participants
@FileEX
Contributor

FileEX commented Jul 24, 2018

Syntax

bool guiEditIsMasked(element theElement)
int guiEditGetMaxLength(element theElement)

guiEditIsMasked - nil if bad argument
guiEditGetMaxLength - false if bad argument

FileEX added some commits Jul 24, 2018

@CrosRoad95

This comment has been minimized.

Show comment
Hide comment
@CrosRoad95

CrosRoad95 Jul 24, 2018

Contributor

guiEditIsMasked - nil if bad argument no, not nil, should return false

Contributor

CrosRoad95 commented Jul 24, 2018

guiEditIsMasked - nil if bad argument no, not nil, should return false

@patrikjuvonen

This comment has been minimized.

Show comment
Hide comment
@patrikjuvonen

patrikjuvonen Jul 24, 2018

Collaborator

Actually it makes sense for it to return nil here because false would imply that the element provided is not masked.

Collaborator

patrikjuvonen commented Jul 24, 2018

Actually it makes sense for it to return nil here because false would imply that the element provided is not masked.

FileEX and others added some commits Jul 24, 2018

@qaisjp

qaisjp approved these changes Jul 24, 2018

@qaisjp qaisjp merged commit 6622c67 into multitheftauto:master Jul 24, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP ready for review
Details

@qaisjp qaisjp changed the title from [Request] Add missing guiEditGetMaxLength & guiEditIsMasked functions to Add missing guiEditGetMaxLength & guiEditIsMasked functions Jul 24, 2018

@qaisjp

This comment has been minimized.

Show comment
Hide comment
@qaisjp

qaisjp Jul 24, 2018

Member

Thanks for your pull request! Good work.

FYI, no need to include [Request]

Member

qaisjp commented Jul 24, 2018

Thanks for your pull request! Good work.

FYI, no need to include [Request]

@patrikjuvonen patrikjuvonen added this to In progress in release/v1.5.6 via automation Aug 7, 2018

@patrikjuvonen patrikjuvonen added this to the 1.5.6 milestone Aug 7, 2018

@patrikjuvonen patrikjuvonen moved this from In progress to Done in release/v1.5.6 Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment