New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "noiseEnabled" parameter to setCameraGoggleEffect #324

Merged
merged 1 commit into from Aug 16, 2018

Conversation

Projects
4 participants
@samr46
Contributor

samr46 commented Aug 15, 2018

Function: setCameraGoggleEffect

New syntax: setCameraGoggleEffect ( string goggleEffect, [ bool noiseEnabled = true ] )

This is a small option to toggle annoying noise effect.
Preview: https://imgur.com/a/cXcE2g9

Add "noiseEnabled" parameter to setCameraGoggleEffect
New syntax: setCameraGoggleEffect ( string goggleEffect, [ bool noiseEnabled = true ] )
@qaisjp

qaisjp approved these changes Aug 15, 2018

Looks good to me.

@multitheftauto/blue-contributors - please can someone give a secondary review?

@ccw808

This comment has been minimized.

Show comment
Hide comment
@ccw808

ccw808 Aug 15, 2018

Member

Looks good to me as well.

Member

ccw808 commented Aug 15, 2018

Looks good to me as well.

@qaisjp qaisjp added the enhancement label Aug 15, 2018

@qaisjp qaisjp merged commit dcd1218 into multitheftauto:master Aug 16, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@patrikjuvonen patrikjuvonen added this to In progress in release/v1.5.6 via automation Aug 23, 2018

@patrikjuvonen patrikjuvonen added this to the 1.5.6 milestone Aug 23, 2018

@patrikjuvonen patrikjuvonen moved this from In progress to Done in release/v1.5.6 Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment