Skip to content

Make objects respawnable by default #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2024
Merged

Make objects respawnable by default #3754

merged 1 commit into from
Sep 28, 2024

Conversation

@TheNormalnij
Copy link
Member

@TheNormalnij TheNormalnij commented Sep 28, 2024

Fixes missing objects and collisions on serverside objects after a player damage them.

@TheNormalnij TheNormalnij added the bugfix Solution to a bug of any kind label Sep 28, 2024
@TheNormalnij TheNormalnij added this to the 1.6.1 milestone Sep 28, 2024
Nico8340
Nico8340 approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@Nico8340 Nico8340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dutchman101
Copy link
Member

Dutchman101 commented Sep 28, 2024 •
edited
Loading

Thanks for the quick investigation and fix

The bug is described as follows:
a1
It can make custom maps collisionless/players will fall thru the ground. Workaround isn't neccesary after the upcoming nightly with fix included. Server nightly (and the one in full installer), as only updated servers were affected.

Was caused by 9d65bb6 (PR #3450)

@Dutchman101 Dutchman101 merged commit ed2d08f into multitheftauto:master Sep 28, 2024
6 checks passed
@TheNormalnij TheNormalnij deleted the TheNormalnij/obj_fix branch September 28, 2024 21:54
MTABot pushed a commit that referenced this pull request Sep 28, 2024
@github-actions
Synchronize changes from 1.6 master branch [ci skip]
4da2cdd 
ed2d08f Fix new world/floor collision bug: Make objects respawnable by default (#3754)
20a161d Update client en_US pot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Nico8340 Nico8340 Nico8340 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix Solution to a bug of any kind

Projects

None yet

Milestone

1.7

Development

Successfully merging this pull request may close these issues.

3 participants

@TheNormalnij @Dutchman101 @Nico8340