Permalink
Commits on Jan 14, 2017
  1. Merge pull request #62 from lopezloo/bugfix/creepysounds

    [editor] Stop creeping out mappers
    Jusonex committed on GitHub Jan 14, 2017
  2. Add freeroam anti-command spam to block crafted attack methods to cau…

    …se lag (#60)
    
    * Block a type of server (lag) flooding in freeroam setskin
    
    I recently got to meet a way for players to mass-lag the server, putting heavy load on it through setting skin in F1 set skin GUI repeatedly hitting 'set' button in teamwork with a few other players. Since the function is expensive and serverside, spamming the button with some other players can cause significant lagspikes on the victim server.
    
    This patch fixes the vulnerability because the effectiveness of that attack type relies on firing the setskin function very rapidly, this patch prevents the unnecesary processing of the set skin when the same skin they are applying is already the current skin.
    It works because achieving high 'set' button press rates doesn't work if they got to select another skin time over time, this makes them lose seconds that make or break the lag effect.
    
    * Second patch of lag-inducing attack method in Freeroam
    
    Addition to previous commit, also prevent setskin command method of same server lagging method
    
    * Addendum to fit coding guidelines
    
    Following code review/arran's comments
    
    * Improvement: detect deliberate spam/macro on command and block
    
    This change also temporarily (10s) ignores requests from a client deliberately spamming the command.
    Legitimate use f.e an player wanting to do something faster, doesn't reach the speeds of triggering command this detection goes off on.
    
    Compare when I can safely hit at rate botched by only the 2 seconds timer (first part of video): https://www.youtube.com/watch?v=ZuCyICDeOhg
    versus near video end the (almost inhumane) speed I start hitting the bind like a madman, which is where the 10 sec command ignore kicks in.
    
    So, this improvement further protects against deliberate spammers by fencing off even more than the 2 seconds limit (they would be able to induce lag every 2 seconds otherwise when with much more players doing it even if limited to 2s)
    without impacting gameplay of legitimate players just looking to speed something up.
    
    * Added protection to final server-call functions that are vulnerable to same type of attack
    
    Enabled the timer and deliberate spam detector to the remaining server-calling functions aswell capable of inducing lag/load in the same manner as setskin function.
    
    * Move settings to meta.xml
    
    Per the codereview recommendations
    
    * Move settings to meta.xml #2
    
    * Improvements
    
    Changed .lua settings to meta and also several logic improvements, most of all terminating any interference with gameplay experience even further than asked in codereview by removing the once-per-2 seconds limitation for commands, and instead only detecting many commands fired *within* 2 seconds, more accurately detecting intended spam but only triggering the suspend of calls from spamming client if it's fired at excessive rates (the default value in meta is 5, pressing a bind/command 5 times within 2 seconds is unusual)
    
    Also added the same protection mechanism for the give weapons/ammo GUI, as it can be abused in a similar way and the serverside function is also pretty expensive, capable to cause lag if spammed excessively. Will by default also trigger when hit 5 times within 2 seconds.
    
    * tweak code
    
    * fix typos
    Dutchman101 committed with Jusonex Jan 14, 2017
Commits on Jan 6, 2017
  1. [editor] Stop creeping out mappers

    (disable CJ breathing and other related sounds in editor mode)
    These sounds still works in test mode (thanks to resetMapInfo
    somewhere).
    lopezloo committed Jan 6, 2017
Commits on Jan 3, 2017
  1. [race] Replaced deprecated showPlayerHudComponent with setPlayerHudCo…

    …mponentVisible
    sbx320 committed on GitHub Jan 3, 2017
Commits on Jan 2, 2017
  1. Merge pull request #38 from nokizorque/playerblips

    [playerblips] Added team functionality
    ArranTuna committed on GitHub Jan 2, 2017
Commits on Dec 30, 2016
  1. Removed 'setblipscolor'

    nokizorque committed Dec 30, 2016
Commits on Dec 25, 2016
  1. Suggested improvements

    nokizorque committed Dec 25, 2016
Commits on Dec 24, 2016
  1. Merge pull request #59 from Dutchman101/master

    Fixed /anim abusable glitch
    ArranTuna committed on GitHub Dec 24, 2016
  2. [killmessages] Fixed vehicle kills not being displayed properly

    1. Explosive kills like Hydra didn't show killer and displayed a fist or
    explosion symbol now they display the killer and Hydra symbol.
    2. Rhino kills were displaying as fist kills, they now display as Rhino
    kills. For some reason onClientPlayerWasted is returning the driver when
    using Rhino but most other vehicles would return the vehicle and that
    was preventing it from getting the used vehicle.
    ArranTuna committed Dec 24, 2016
Commits on Nov 24, 2016
  1. Addendum to 68d90ab (fix /anim abusable glitch)

    qaisjp committed on GitHub Nov 24, 2016
Commits on Nov 22, 2016
  1. Fixed /anim abusable glitch

    This patch blocks 2 anims from being used directly by /anim command rather than GUI, because they were abusable in combat with other players; the anim makes their ped go underground (under the world) so that they suddenly become invisible and unharmable by gunfire since within split second they'd be gone from sight (in reality just under the attacker's feet)
    
    It could be used by command at the moment player almost dies with low HP, to prevent any attack from other player to succeed. It's unfair advantage.
    Dutchman101 committed on GitHub Nov 22, 2016
Commits on Oct 29, 2016
Commits on Oct 13, 2016
Commits on Sep 30, 2016
  1. Merge pull request #54 from PhrozenByte/patch-2

    Race: Fix onGamemodeMapStop event
    Jusonex committed on GitHub Sep 30, 2016
Commits on Aug 26, 2016
Commits on Aug 18, 2016
  1. Race: Fix onGamemodeMapStop event

    PhrozenByte committed on GitHub Aug 18, 2016
Commits on Aug 12, 2016
  1. Let the editor EDF scriptreader support OOP (#52)

    Doesn't break anything and allows resource developers to use OOP in resources with editor support
    PhrozenByte committed with qaisjp Aug 12, 2016
Commits on Aug 7, 2016
  1. Addendum to #50: fix GUI look on dropdown (#51)

    Fix something I missed out on @ last PR #50, making the GUI dropdown menu for bantime type look better.
    Dutchman101 committed with darkdreamingdan Aug 7, 2016
Commits on Aug 6, 2016
  1. [webbrowser] fix oop typo

    qaisjp committed on GitHub Aug 6, 2016
  2. Add unban date to bans and allow defining custom ban times for offlin…

    …e bans (#50)
    
    Add unban date + ban time to offline bans (serial / IP)
    Dutchman101 committed with darkdreamingdan Aug 6, 2016
Commits on Jul 31, 2016
Commits on Jul 29, 2016
Commits on Jul 25, 2016
  1. Addendum to PR #48: fix inconsistency (#49)

    This commit fixes something I missed out on last PR; conform all bans to set banning admin to their accountname instead of nick.
    It was meant to be the main feature of custom serial & IP ban, yet I missed it on these especially.
    Dutchman101 committed with qaisjp Jul 25, 2016
  2. Add GUI options on serial / IP ban: Reason & nick (#48)

    Implement possibility to manually add ban reason & player nick when banning a specific serial of offline player through adminpanel.
    Previously, not meeting a player in-game and banning per serial resulted in reason-less / nick-less bans that only contained the serial in banlist using adminpanel.
    Dutchman101 committed with qaisjp Jul 25, 2016
Commits on Jul 9, 2016
Commits on Jul 5, 2016
  1. Fixed #9089: Stealth kills have a 5 second delay after warping

    To fix abuse of warping and instakilling, there's a 5 second delay
    before you can execute a stealth kill.  This can be switched off by
    setting "weapons/kniferestrictions" to false.
    
    https://bugs.mtasa.com/view.php?id=9089
    darkdreamingdan committed Jul 5, 2016
Commits on Jun 29, 2016
  1. Merge pull request #47 from Dutchman101/master

    Fix anonymous-admin option to really be anonymous
    qaisjp committed on GitHub Jun 29, 2016
Commits on Jun 16, 2016
Commits on Jun 15, 2016
  1. Addendum to last commit

    Register accountname of banning admin in bans list if anonymous, and show victim Anonymous admin banned them (before this commit it'd be 'Console'
    Dutchman101 committed on GitHub Jun 15, 2016
Commits on Jun 14, 2016
  1. Fix anonymous-admin option to really be anonymous

    This fixes several occasions on which the admin's nickname would be exposed and shown to the victim.
    After this commit, the Anonymous admin tickbox really hides all occasions on which their name would not be hidden, as when the bug existed.
    Dutchman101 committed on GitHub Jun 14, 2016
Commits on Mar 1, 2016
  1. Merge pull request #40 from AboShanab/master

    Fix problem some times give bad argument at freeroam
    ccw808 committed Mar 1, 2016