Fix duplicated txs into tx pool api response #4424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with id = shard_otherShard as they point to the same one
sstanculeanu
added
type:bug
andreibancioiu
approved these changes
Aug 31, 2022
|
|
||
| txs := txCache.GetTransactionsPoolForSender(sender) | ||
| txsForSender = append(txsForSender, txs...) | ||
| cacheId := process.ShardCacherIdentifier(senderShard, senderShard) |
There was a problem hiding this comment.
so this will work despite the fact that a transaction might be cross shard? On both nodes: sender & destination?
There was a problem hiding this comment.
yes, as verified with @andreibancioiu and can be seen here, no matter the destination shard, there will always be returned the source id.
the problem was observed on a transaction from shard 0 to shard 1, when the same transaction was returned 4 times from a shard 0 observer.
also, @gabi-vuls confirmed that testing was made with cross shard txs.
iulianpascalau
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)
/transaction/pool?by-sender=erd1...asShardDataStorereturns the same data storer for all ids "0", "0_1", "0_2", "0_META"Proposed Changes
sourceShard_destinationShardas they all point to the same one, leading to duplicatesTesting procedure
/transaction/poolon the observer from the shard you sent txsf and copy a sender address)/transaction/pool?by-sender=sender_addr_from_above_pointon either proxy or intra shard observer, tyou should not the duplicates among tx hashes received in response