fix custom meta DB remover #4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
added
type:bug
andreibancioiu
previously approved these changes
Oct 25, 2022
SebastianMarian
previously approved these changes
Oct 25, 2022
| @@ -301,6 +300,9 @@ func (psf *StorageServiceFactory) CreateForShard() (dataRetriever.StorageService | |||
| return store, err | |||
| } | |||
|
|
|||
| // TODO: split in 2 components shardStorageServiceCreator and metStorageServiceCreator that have a base which will contain the | |||
There was a problem hiding this comment.
typo: metStorageServiceCreator
There was a problem hiding this comment.
I've expected the proper refactor work
iulianpascalau
requested changes
Oct 25, 2022
| @@ -301,6 +300,9 @@ func (psf *StorageServiceFactory) CreateForShard() (dataRetriever.StorageService | |||
| return store, err | |||
| } | |||
|
|
|||
| // TODO: split in 2 components shardStorageServiceCreator and metStorageServiceCreator that have a base which will contain the | |||
There was a problem hiding this comment.
I've expected the proper refactor work
iulianpascalau
dismissed stale reviews from SebastianMarian and andreibancioiu
via
7d63b9e
iulianpascalau
previously approved these changes
Oct 27, 2022
SebastianMarian
approved these changes
Oct 27, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.4.0 #4642 +/- ##
============================================
Coverage ? 70.83%
============================================
Files ? 630
Lines ? 83248
Branches ? 0
============================================
Hits ? 58972
Misses ? 19864
Partials ? 4412 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
andreibancioiu
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?