Skip to content

Conversation

@andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented Apr 15, 2022

The dependency was removed by mistake when extracting the walletcore package to a separate repository.

The issue was not detected before, since blake2b was present in node_modules, as erdjs-walletcore is added as a dev-dependency in erdjs (only for integration tests). Furthermore, it seems that browserify (used to prepare the bundles for browser tests) was picking up the dependency from node_modules, as well.

When building using webpack, make sure you include the following fallback, as well:

npm install stream-browserify --save-dev

Then, in webpack's configuration file:

fallback: {
    stream: require.resolve("stream-browserify")
}

@andreibancioiu andreibancioiu self-assigned this Apr 15, 2022
@andreibancioiu andreibancioiu merged commit 58e9cc6 into main Apr 18, 2022
@andreibancioiu andreibancioiu deleted the reference-blake2b branch April 18, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants